Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(607)

Issue 4433068: [patch] Fix DWARF so types with subprogram definitions don't get moved to type unit (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 11 months ago by Cary
Modified:
12 years, 11 months ago
Reviewers:
Jason Merrill, jason
CC:
gcc-patches_gcc.gnu.org
Visibility:
Public.

Description

commit a4741baea91a023f0086f22709b78164ed9ef89e Author: Cary Coutant <ccoutant@google.com> Date: Mon Apr 25 13:54:19 2011 -0700 Check for classes that contain defining declarations of subprograms, and do not move such classes into a comdat type unit. M gcc/dwarf2out.c Tested: Bootstrapped on x86_64. ChangeLog: 2011-04-25 Cary Coutant <ccoutant@google.com> * gcc/dwarf2out.c (contains_subprogram_definition): New function. (should_move_die_to_comdat): Call it.

Patch Set 1 #

Patch Set 2 : [patch] Fix DWARF so types with subprogram definitions don't get moved to type unit (issue4433068) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M gcc/dwarf2out.c View 1 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 6
Cary
In GCC 4.4.3, I found a case where a defining declaration of a subprogram was ...
12 years, 11 months ago (2011-04-25 21:27:08 UTC) #1
Jason Merrill
It's a good check to add, but if it returns true we should abort rather ...
12 years, 11 months ago (2011-05-05 21:13:39 UTC) #2
Cary
> It's a good check to add, but if it returns true we should abort ...
12 years, 11 months ago (2011-05-05 21:33:14 UTC) #3
jason_redhat.com
On 05/05/2011 05:33 PM, ccoutant@google.com wrote: > I couldn't convince myself that a subprogram definition ...
12 years, 11 months ago (2011-05-05 21:42:33 UTC) #4
Cary
commit bf6ab23aad749d927108ace21ee01a94af31a38b Author: Cary Coutant <ccoutant@google.com> Date: Mon Apr 25 13:54:19 2011 -0700 Check for ...
12 years, 11 months ago (2011-05-06 00:38:55 UTC) #5
jason_redhat.com
12 years, 11 months ago (2011-05-06 04:50:35 UTC) #6
OK.

Jason
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b