Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(564)

Issue 4433059: Add org.freedesktop.IBus.InputContext.ProcessHandWritingEvent and .CancelHandWri (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 11 months ago by Yusuke Sato
Modified:
12 years, 11 months ago
Reviewers:
shawn.p.huang, Peng Huang, Peng
CC:
zork, bryeung, mazda
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

Add org.freedesktop.IBus.InputContext.ProcessHandWritingEvent and CancelHandWriting to support a handwriting engine.

Patch Set 1 #

Patch Set 2 : review #

Patch Set 3 : review #

Total comments: 14

Patch Set 4 : review fix #

Patch Set 5 : review fix #

Total comments: 12

Patch Set 6 : review fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+285 lines, -2 lines) Patch
M bus/engineproxy.h View 1 2 3 4 5 1 chunk +19 lines, -0 lines 0 comments Download
M bus/engineproxy.c View 1 2 3 4 5 1 chunk +34 lines, -0 lines 0 comments Download
M bus/inputcontext.c View 1 2 3 4 5 3 chunks +38 lines, -0 lines 0 comments Download
M src/ibusengine.h View 1 2 3 4 5 1 chunk +8 lines, -1 line 0 comments Download
M src/ibusengine.c View 1 2 3 4 5 7 chunks +104 lines, -0 lines 0 comments Download
M src/ibusinputcontext.h View 1 2 3 4 5 1 chunk +36 lines, -0 lines 0 comments Download
M src/ibusinputcontext.c View 1 2 3 4 5 2 chunks +45 lines, -1 line 0 comments Download
M src/ibusmarshalers.list View 1 4 5 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9
Yusuke Sato
12 years, 11 months ago (2011-04-20 12:27:47 UTC) #1
Peng
http://codereview.appspot.com/4433059/diff/3001/src/ibusengine.c File src/ibusengine.c (right): http://codereview.appspot.com/4433059/diff/3001/src/ibusengine.c#newcode657 src/ibusengine.c:657: * Emitted when a hand writing operation is canceled. ...
12 years, 11 months ago (2011-04-20 21:27:31 UTC) #2
Yusuke Sato
http://codereview.appspot.com/4433059/diff/3001/src/ibusengine.c File src/ibusengine.c (right): http://codereview.appspot.com/4433059/diff/3001/src/ibusengine.c#newcode657 src/ibusengine.c:657: * Emitted when a hand writing operation is canceled. ...
12 years, 11 months ago (2011-04-21 04:07:00 UTC) #3
Yusuke Sato
+Zach,Bryan I'm implementing ibus-daemon and libibus parts of https://docs.google.com/a/google.com/document/d/1jn4gWdXrq28pBqiOD7sImKC0YP5V8GFB-ic8T6AeEOM/edit?authkey=CIqW0s4G&hl=en# . Could you check if the ...
12 years, 11 months ago (2011-04-21 04:13:06 UTC) #4
Peng
http://codereview.appspot.com/4433059/diff/3001/src/ibusengine.c File src/ibusengine.c (right): http://codereview.appspot.com/4433059/diff/3001/src/ibusengine.c#newcode943 src/ibusengine.c:943: while (g_variant_iter_next (iter, "d", p++)); /* you can't use ...
12 years, 11 months ago (2011-04-21 04:45:52 UTC) #5
Yusuke Sato
http://codereview.appspot.com/4433059/diff/3001/src/ibusengine.c File src/ibusengine.c (right): http://codereview.appspot.com/4433059/diff/3001/src/ibusengine.c#newcode943 src/ibusengine.c:943: while (g_variant_iter_next (iter, "d", p++)); /* you can't use ...
12 years, 11 months ago (2011-04-21 05:43:09 UTC) #6
Peng
http://codereview.appspot.com/4433059/diff/1010/bus/inputcontext.c File bus/inputcontext.c (right): http://codereview.appspot.com/4433059/diff/1010/bus/inputcontext.c#newcode794 bus/inputcontext.c:794: if (context->has_focus && context->enabled && context->engine && context->fake == ...
12 years, 11 months ago (2011-04-21 14:17:33 UTC) #7
Yusuke Sato
http://codereview.appspot.com/4433059/diff/1010/bus/inputcontext.c File bus/inputcontext.c (right): http://codereview.appspot.com/4433059/diff/1010/bus/inputcontext.c#newcode794 bus/inputcontext.c:794: if (context->has_focus && context->enabled && context->engine && context->fake == ...
12 years, 11 months ago (2011-04-22 03:52:21 UTC) #8
Peng
12 years, 11 months ago (2011-04-22 11:01:48 UTC) #9
LGTM.

On 2011/04/22 03:52:21, Yusuke Sato wrote:
> http://codereview.appspot.com/4433059/diff/1010/bus/inputcontext.c
> File bus/inputcontext.c (right):
> 
> http://codereview.appspot.com/4433059/diff/1010/bus/inputcontext.c#newcode794
> bus/inputcontext.c:794: if (context->has_focus && context->enabled &&
> context->engine && context->fake == FALSE) {
> On 2011/04/21 14:17:33, Peng wrote:
> > The line is too long. Please split them to several lines
> 
> Done.
> 
> http://codereview.appspot.com/4433059/diff/1010/bus/inputcontext.c#newcode809
> bus/inputcontext.c:809: if (context->has_focus && context->enabled &&
> context->engine && context->fake == FALSE) {
> On 2011/04/21 14:17:33, Peng wrote:
> > The line is too long. Please split them to several lines
> 
> Done.
> 
> http://codereview.appspot.com/4433059/diff/1010/src/ibusengine.c
> File src/ibusengine.c (right):
> 
> http://codereview.appspot.com/4433059/diff/1010/src/ibusengine.c#newcode159
> src/ibusengine.c:159: gint                n_strokes);
> On 2011/04/21 14:17:33, Peng wrote:
> > How about use guint.
> > and n_strokers == 0 means cancel all strokes.
> 
> Done.
> 
> http://codereview.appspot.com/4433059/diff/1010/src/ibusengine.c#newcode680
> src/ibusengine.c:680: *
> On 2011/04/21 14:17:33, Peng wrote:
> > @n_strokes ?
> 
> Done.
> 
> http://codereview.appspot.com/4433059/diff/1010/src/ibusengine.c#newcode1136
> src/ibusengine.c:1136: // g_debug ("process-hand-writing-event (%d)",
> coordinates_len);
> On 2011/04/21 14:17:33, Peng wrote:
> > %u?
> 
> Done.
> 
> http://codereview.appspot.com/4433059/diff/1010/src/ibusinputcontext.h
> File src/ibusinputcontext.h (right):
> 
>
http://codereview.appspot.com/4433059/diff/1010/src/ibusinputcontext.h#newcod...
> src/ibusinputcontext.h:203: gsize               coordinates_len);
> On 2011/04/21 14:17:33, Peng wrote:
> > How about use guint here? Because I found you use guint in IBusEngine.
> 
> Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b