Fine, but how will we prevent this from breaking again in the future? How do ...
13 years, 6 months ago
(2011-04-20 15:24:14 UTC)
#2
Fine, but how will we prevent this from breaking again in the future? How do we
know that all //// comments throughout the code base have the same length? I
think this change requires a new unit test that parses all the code on each
checkin to verify comment consistency.
LGTM.
On 2011/04/20 15:04:27, epoger wrote:
On 2011/04/20 15:24:14, bsalomon wrote: > Fine, but how will we prevent this from breaking ...
13 years, 6 months ago
(2011-04-20 15:34:26 UTC)
#3
On 2011/04/20 15:24:14, bsalomon wrote:
> Fine, but how will we prevent this from breaking again in the future? How do
we
> know that all //// comments throughout the code base have the same length? I
> think this change requires a new unit test that parses all the code on each
> checkin to verify comment consistency.
>
> LGTM.
>
> On 2011/04/20 15:04:27, epoger wrote:
A very good point. Ignoring.
Issue 4432053: tiny test change
(Closed)
Created 13 years, 6 months ago by epoger
Modified 13 years, 6 months ago
Reviewers: bsalomon
Base URL: http://skia.googlecode.com/svn/trunk/tests/
Comments: 0