Issue 4431067: Add a SKIA_SHARED flag to the Makefile to build skia as a shared object.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4431067: Add a SKIA_SHARED flag to the Makefile to build skia as a shared object.

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by evan

Modified:
13 years, 7 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Add a SKIA_SHARED flag to the Makefile to build skia as a shared object. - Add a libskia.so target that uses gcc -shared rather than ar to link. - Adjust binaries so they use whichever skia library we've configured.

Patch Set 1 #

Total comments: 1

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -10 lines)			Patch
	M	Makefile	View		8 chunks	+21 lines, -10 lines	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

evan

http://codereview.appspot.com/4431067/diff/1/Makefile File Makefile (right): http://codereview.appspot.com/4431067/diff/1/Makefile#newcode168 Makefile:168: $(HIDE)$(GPP) -shared -o $@ $(OBJ_LIST) $(JUST_COMPILE_OBJS) $(LINKER_OPTS) Note that ...

13 years, 7 months ago (2011-04-26 19:48:01 UTC) #1

LGTM

Committed revision 1194.

Expand All Messages | Collapse All Messages