Changes PPCallback to export the search path in InclusionDirective

To be able to replay compilations we need to accurately remodel how includes get resolved, especially when they are found relatively to another include file. We also try to get it working for framework includes, but that part of the code is untested, as I don't have a code base that uses it.

[chandlerc, 2011-04-26 17:48:04]

http://codereview.appspot.com/4430065/diff/1/include/clang/Lex/DirectoryLookup.h
File include/clang/Lex/DirectoryLookup.h (right):

http://codereview.appspot.com/4430065/diff/1/include/clang/Lex/DirectoryLooku...
include/clang/Lex/DirectoryLookup.h:125: /// If RawPath is not NULL and the file
is found, RawPath will be set to the
Need to update the doxyments.

Want to make them proper doxyments with \params?

http://codereview.appspot.com/4430065/diff/1/include/clang/Lex/HeaderSearch.h
File include/clang/Lex/HeaderSearch.h (right):

http://codereview.appspot.com/4430065/diff/1/include/clang/Lex/HeaderSearch.h...
include/clang/Lex/HeaderSearch.h:196: llvm::SmallVectorImpl<char> *SearchPath,
These aren't mentioned at all in the doxyments. Should they be?

http://codereview.appspot.com/4430065/diff/1/include/clang/Lex/PPCallbacks.h
File include/clang/Lex/PPCallbacks.h (right):

http://codereview.appspot.com/4430065/diff/1/include/clang/Lex/PPCallbacks.h#...
include/clang/Lex/PPCallbacks.h:80: /// in the file system.
Mention that if unused, this is defined to be empty?

http://codereview.appspot.com/4430065/diff/1/include/clang/Lex/PPCallbacks.h#...
include/clang/Lex/PPCallbacks.h:85: /// path
"path/to/Frameworks/Some.framework/Headers/Some.h", SearchPath
Part of this is about SearchPath, should it be attached to the previous comment?

http://codereview.appspot.com/4430065/diff/1/lib/Lex/HeaderSearch.cpp
File lib/Lex/HeaderSearch.cpp (right):

http://codereview.appspot.com/4430065/diff/1/lib/Lex/HeaderSearch.cpp#newcode130
lib/Lex/HeaderSearch.cpp:130: *SearchPath =
llvm::SmallString<1024>(getDir()->getName());
Lets avoid creating a temporary SmallString<1024> here; just ->clean() and
->append(begin, end)?

http://codereview.appspot.com/4430065/diff/1/lib/Lex/HeaderSearch.cpp#newcode261
lib/Lex/HeaderSearch.cpp:261: *SearchPath = llvm::SmallString<0>();
->clear()

[klimek, 2011-04-26 18:38:43]

http://codereview.appspot.com/4430065/diff/1/include/clang/Lex/DirectoryLookup.h
File include/clang/Lex/DirectoryLookup.h (right):

http://codereview.appspot.com/4430065/diff/1/include/clang/Lex/DirectoryLooku...
include/clang/Lex/DirectoryLookup.h:125: /// If RawPath is not NULL and the file
is found, RawPath will be set to the
On 2011/04/26 17:48:04, chandlerc wrote:
> Need to update the doxyments.
> 
> Want to make them proper doxyments with \params?

Done.

http://codereview.appspot.com/4430065/diff/1/include/clang/Lex/HeaderSearch.h
File include/clang/Lex/HeaderSearch.h (right):

http://codereview.appspot.com/4430065/diff/1/include/clang/Lex/HeaderSearch.h...
include/clang/Lex/HeaderSearch.h:196: llvm::SmallVectorImpl<char> *SearchPath,
On 2011/04/26 17:48:04, chandlerc wrote:
> These aren't mentioned at all in the doxyments. Should they be?

Done.

http://codereview.appspot.com/4430065/diff/1/include/clang/Lex/PPCallbacks.h
File include/clang/Lex/PPCallbacks.h (right):

http://codereview.appspot.com/4430065/diff/1/include/clang/Lex/PPCallbacks.h#...
include/clang/Lex/PPCallbacks.h:80: /// in the file system.
On 2011/04/26 17:48:04, chandlerc wrote:
> Mention that if unused, this is defined to be empty?

Done.

http://codereview.appspot.com/4430065/diff/1/include/clang/Lex/PPCallbacks.h#...
include/clang/Lex/PPCallbacks.h:85: /// path
"path/to/Frameworks/Some.framework/Headers/Some.h", SearchPath
On 2011/04/26 17:48:04, chandlerc wrote:
> Part of this is about SearchPath, should it be attached to the previous
comment?

Done.

http://codereview.appspot.com/4430065/diff/1/lib/Lex/HeaderSearch.cpp
File lib/Lex/HeaderSearch.cpp (right):

http://codereview.appspot.com/4430065/diff/1/lib/Lex/HeaderSearch.cpp#newcode130
lib/Lex/HeaderSearch.cpp:130: *SearchPath =
llvm::SmallString<1024>(getDir()->getName());
On 2011/04/26 17:48:04, chandlerc wrote:
> Lets avoid creating a temporary SmallString<1024> here; just ->clean() and
> ->append(begin, end)?

Done.

http://codereview.appspot.com/4430065/diff/1/lib/Lex/HeaderSearch.cpp#newcode261
lib/Lex/HeaderSearch.cpp:261: *SearchPath = llvm::SmallString<0>();
On 2011/04/26 17:48:04, chandlerc wrote:
> ->clear()

Done.

[chandlerc, 2011-04-26 18:51:58]

http://codereview.appspot.com/4430065/diff/6001/include/clang/Lex/DirectoryLo...
File include/clang/Lex/DirectoryLookup.h (right):

http://codereview.appspot.com/4430065/diff/6001/include/clang/Lex/DirectoryLo...
include/clang/Lex/DirectoryLookup.h:134: /// SearchPath at which the file was
found. This only not equal to Filename
s/This only not equal to/This only differs from the/

http://codereview.appspot.com/4430065/diff/6001/include/clang/Lex/HeaderSearch.h
File include/clang/Lex/HeaderSearch.h (right):

http://codereview.appspot.com/4430065/diff/6001/include/clang/Lex/HeaderSearc...
include/clang/Lex/HeaderSearch.h:203: /// SearchPath at which the file was
found. This only not equal to Filename
Same fix as previous comment.

[klimek, 2011-04-26 18:55:32]

http://codereview.appspot.com/4430065/diff/6001/include/clang/Lex/DirectoryLo...
File include/clang/Lex/DirectoryLookup.h (right):

http://codereview.appspot.com/4430065/diff/6001/include/clang/Lex/DirectoryLo...
include/clang/Lex/DirectoryLookup.h:134: /// SearchPath at which the file was
found. This only not equal to Filename
On 2011/04/26 18:51:58, chandlerc wrote:
> s/This only not equal to/This only differs from the/

Done.

http://codereview.appspot.com/4430065/diff/6001/include/clang/Lex/HeaderSearch.h
File include/clang/Lex/HeaderSearch.h (right):

http://codereview.appspot.com/4430065/diff/6001/include/clang/Lex/HeaderSearc...
include/clang/Lex/HeaderSearch.h:203: /// SearchPath at which the file was
found. This only not equal to Filename
On 2011/04/26 18:51:58, chandlerc wrote:
> Same fix as previous comment.

Done.

[chandlerc, 2011-04-26 21:45:09]

LGTM

(after you made the changes requested inside of rietveld)

Feel free to submit.

On Mon, Apr 25, 2011 at 6:22 PM, <klimek@google.com> wrote:

> Reviewers: chandlerc1,
>
> Description:
> To be able to replay compilations we need to accurately remodel how
> includes get resolved, especially when they are found relatively to
> another include file. We also try to get it working for framework
> includes, but that part of the code is untested, as I don't have a code
> base that uses it.
>
> Please review this at http://codereview.appspot.com/4430065/
>
> Affected files:
>   M include/clang/Lex/DirectoryLookup.h
>   M include/clang/Lex/HeaderMap.h
>   M include/clang/Lex/HeaderSearch.h
>   M include/clang/Lex/PPCallbacks.h
>   M include/clang/Lex/PreprocessingRecord.h
>   M include/clang/Lex/Preprocessor.h
>   M lib/Lex/HeaderMap.cpp
>   M lib/Lex/HeaderSearch.cpp
>   M lib/Lex/PPDirectives.cpp
>   M lib/Lex/PPMacroExpansion.cpp
>   M lib/Lex/Pragma.cpp
>   M lib/Lex/PreprocessingRecord.cpp
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits@cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>