Issue 4423085: Add comparison and assignment to SkClipStack (and fix an optimization bug).

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4423085: Add comparison and assignment to SkClipStack (and fix an optimization bug). (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by Steve VanDeBogart

Modified:
13 years, 6 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Add comparison and assignment to SkClipStack (and fix an optimization bug). Committed: http://code.google.com/p/skia/source/detail?r=1230

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+146 lines, -1 line)			Patch
M	include/core/SkClipStack.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/core/SkClipStack.cpp	View	2 chunks	+63 lines, -1 line	0 comments	Download
M	tests/ClipStackTest.cpp	View	2 chunks	+78 lines, -0 lines	0 comments	Download

Total messages: 3

Steve VanDeBogart

The new test found a bug in canBeIntersected, fixed in this CL.

13 years, 6 months ago (2011-05-03 03:37:31 UTC) #1

nice set of tests!