Issue 4420041: [PDF] If the clip is empty, we shouldn't bother actually drawing anything.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4420041: [PDF] If the clip is empty, we shouldn't bother actually drawing anything. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by Steve VanDeBogart

Modified:
13 years, 7 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Description

[PDF] If the clip is empty, we shouldn't bother actually drawing anything. Plus, fix ifdef for flate test. Committed: http://code.google.com/p/skia/source/detail?r=1141

Patch Set 2 : Use SkDraw to determine an empty clip #

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -7 lines)			Patch
	M	src/pdf/SkPDFDevice.cpp	View	1	10 chunks	+55 lines, -6 lines	0 comments	Download
	M	tests/FlateTest.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Steve VanDeBogart

Actually nevermind, I combined this with a few other fixes.

13 years, 7 months ago (2011-04-15 01:49:06 UTC) #2

reed1

http://codereview.appspot.com/4420041/diff/1/src/pdf/SkPDFDevice.cpp File src/pdf/SkPDFDevice.cpp (right): http://codereview.appspot.com/4420041/diff/1/src/pdf/SkPDFDevice.cpp#newcode203 src/pdf/SkPDFDevice.cpp:203: void SkPDFDevice::drawPaint(const SkDraw& d, const SkPaint& paint) { why ...

13 years, 7 months ago (2011-04-15 11:55:37 UTC) #3

Steve VanDeBogart

13 years, 7 months ago (2011-04-15 18:40:47 UTC) #4

LGTM

Expand All Messages | Collapse All Messages