Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2601)

Issue 4413047: Generation ID for SkBitmaps with no pixel ref (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 8 months ago by bsalomon
Modified:
13 years, 8 months ago
Reviewers:
reed1
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Use global genID for raw pixels #

Patch Set 3 : acknowledge that sk_atomic_inc returns old value #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -24 lines) Patch
M include/core/SkBitmap.h View 2 chunks +5 lines, -1 line 0 comments Download
M src/core/SkBitmap.cpp View 1 4 chunks +32 lines, -13 lines 0 comments Download
M src/core/SkPixelRef.cpp View 1 2 2 chunks +15 lines, -10 lines 0 comments Download

Messages

Total messages: 4
bsalomon
13 years, 8 months ago (2011-04-14 12:30:52 UTC) #1
bsalomon
Updated to use same global as SkPixelRef On 2011/04/14 12:30:52, bsalomon wrote:
13 years, 8 months ago (2011-04-14 14:22:17 UTC) #2
reed1
very clean LGTM
13 years, 8 months ago (2011-04-14 14:26:14 UTC) #3
bsalomon
13 years, 8 months ago (2011-04-14 15:07:43 UTC) #4
Closed with r1125
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b