Add some polyphonically directed grobs

Add some polyphonically directed grobs

Accidental suggestions, dynamics, ligatures and spanned trills added to direction-polyphonic-grobs.

[Bertrand Bordage, 2011-04-10 01:57:15]

Small patch that takes new grobs in account :
Accidental suggestions, dynamics, ligatures and spanned trills.

Regards,
Bertrand

[Carl, 2011-04-10 02:23:27]

LGTM.

Carl

[cpkc_shaw.ca, 2011-04-10 03:32:25]

On 11-04-09 07:57 PM, bordage.bertrand@gmail.com wrote:
> Reviewers: ,
>
> Message:
> Small patch that takes new grobs in account :
> Accidental suggestions, dynamics, ligatures and spanned trills.
>
> Regards,
> Bertrand
>
> Description:
> Add some polyphonically directed grobs
>
> Accidental suggestions, dynamics, ligatures and spanned trills added to
> direction-polyphonic-grobs.
>
> Please review this at http://codereview.appspot.com/4387046/
>
> Affected files:
>   M scm/music-functions.scm
>
>
> Index: scm/music-functions.scm
> diff --git a/scm/music-functions.scm b/scm/music-functions.scm
> index 
>
9790cbf1a3d145a8524b3e20b1b874c59c117de6..6192cbd4863e69c21ced4fc1bf99ae2ac6fa4daf

> 100644
> --- a/scm/music-functions.scm
> +++ b/scm/music-functions.scm
> @@ -400,10 +400,14 @@ in @var{grob}."
>            'grob-property gprop))
>
>  (define direction-polyphonic-grobs
> -  '(DotColumn
> +  '(AccidentalSuggestion
> +    DotColumn
>      Dots
> +    DynamicLineSpanner
> +    DynamicText
>      Fingering
>      LaissezVibrerTie
> +    LigatureBracket
>      PhrasingSlur
>      RepeatTie
>      Rest
> @@ -411,7 +415,8 @@ in @var{grob}."
>      Slur
>      Stem
>      TextScript
> -    Tie))
> +    Tie
> +    TrillSpanner))
>
>  (define-safe-public (make-voice-props-set n)
>    (make-sequential-music
>
>

I've added issue 1603, Bertrand, just to track the patch.  It compiled 
cleanly on my machine, although it showed a noticeable shift downward of 
the fallback staff in regression/out-test/quote-cue-event-types.ly as 
well as moving the ff dynamic above the staff.

HTH,
Colin Campbell
Bug Squad

-- 
The test of our progress is not whether we add more to the abundance
of those who have much, it is whether we provide enough for those who
have too little.
-Franklin D. Roosevelt, 32nd US President (1882-1945)

[Bertrand Bordage, 2011-04-10 03:43:06]

Yes, I noticed the same changes. That's exactly what I expected.
Thanks,
Bertrand

[Trevor Daniels, 2011-04-10 08:49:07]

LGTM

[Neil Puttock, 2011-04-11 23:53:34]

Hi Bertrand,

There was a discussion last year about dynamics in polyphony which you might
find interesting:

http://lists.gnu.org/archive/html/bug-lilypond/2010-09/msg00253.html

I'm afraid I agree with Trevor's reply in that thread.

Cheers,
Neil

[t.daniels_treda.co.uk, 2011-04-12 08:32:58]

n.puttock@gmail.com:

> There was a discussion last year about dynamics in polyphony which 
> you
> might find interesting:
>
> http://lists.gnu.org/archive/html/bug-lilypond/2010-09/msg00253.html
>
> I'm afraid I agree with Trevor's reply in that thread.

Your memory is better than mine, Neil!  Thanks for pointing
this out.  I clearly thought more carefully about this issue
last year, so I withdraw my LGTM.  Sorry Bertand.

Trevor

[Bertrand Bordage, 2011-04-12 09:37:04]

Ok. But you agree with the other grobs ?

[t.daniels_treda.co.uk, 2011-04-12 11:01:48]

bordage.bertrand@gmail.com


> Ok. But you agree with the other grobs ?

I'm not sure (best be cautious this time :)

In keyboard music multiple voices have to be used
when notes with different durations occur at the
same time, but normally a cautionary accidental
would be placed above the staff whichever voice
was involved.  Rather like dynamics, a different
placement would be required (for clarity) only when 
both voices were active.  Which situation is the 
more common?  That should determine the default 
setting.

I think the same consideration applies to TrillSpanner.

I'm not familiar enough with LigatureBracket to
hold an opinion.

Trevor

[pkx166h, 2011-08-28 10:01:10]

Patch fails on tree as of 28 August.

patching file scm/music-functions.scm
Hunk #2 FAILED at 415.
1 out of 2 hunks FAILED -- saving rejects to file scm/music-functions.scm.rej
jlowe@jlowe-lilybuntu2:~/lilypond-git$

[Bertrand Bordage, 2011-08-29 12:27:05]

Updated.

Bertrand

[pkx166h, 2011-08-30 21:46:01]

Passes make but get two reg tests show up that look ok but that need a second
opinion.

Attached on

http://code.google.com/p/lilypond/issues/detail?id=1854#c1

[Trevor Daniels, 2011-09-01 22:05:39]

I don't think we have sufficient support for applying this patch.  Both Neil and
I have spoken against it, and presented our arguments.  No one has given a
counter view.

[Bertrand Bordage, 2011-09-06 16:42:34]

Ok, DynamicText and DynamicLineSpanner should be removed.
But what about the others?

* Simple trill is directed (as a Script), so TrillSpanner logically has to be
directed.

* Slurs, Ties and TupletBrackets are also directed, so I don't see any reason
for LigatureBrackets to behave differently.

* AccidentalSuggestion in polyphony leads to mistakes if it isn't directed.

Bertrand

[janek, 2011-09-12 20:30:01]

On 2011/09/06 16:42:34, Bertrand Bordage wrote:
> Ok, DynamicText and DynamicLineSpanner should be removed.
> But what about the others?

I think they should be added.

cheers,
Janek

[Bertrand Bordage, 2011-09-15 18:14:45]

Great. I removed the dynamics.

Is someone opposed to this patch to be pushed?
I suggest we put this issue in the next countdown.

Thanks,
Bertrand

[Neil Puttock, 2011-09-15 22:23:52]

LGTM.

[pkx166h, 2011-09-16 21:56:08]

Passes make and reg tests. I did get the 'NOT A BUG' test show up again, I see
that I had had this before...so this looks ok.

See: http://code.google.com/p/lilypond/issues/detail?id=1854#c1

James

[Bertrand Bordage, 2011-09-19 07:41:01]

Pushed as f9251331576c94fa6aa4b85776917d3774b13b63