Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1277)

Issue 4384050: Issue 1471: Invalidate alterations upon key change rather than forgetting them. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 11 months ago by dak
Modified:
12 years, 11 months ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 1471: Invalidate alterations upon key change rather than forgetting them. See <URL:http://code.google.com/p/lilypond/issues/detail?id=1471>

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address Keith's comment and rename accidental-voided? to accidental-invalid? #

Patch Set 3 : Add a separate regtest (to be committed in a separate commit before the rest). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -19 lines) Patch
A input/regression/accidental-clef-change2.ly View 1 2 1 chunk +18 lines, -0 lines 0 comments Download
M lily/clef-engraver.cc View 2 chunks +11 lines, -3 lines 0 comments Download
M scm/music-functions.scm View 1 6 chunks +52 lines, -16 lines 0 comments Download

Messages

Total messages: 14
Graham Percival (old account)
LGTM
12 years, 11 months ago (2011-04-10 05:38:50 UTC) #1
Valentin Villenave
On 2011/04/10 05:38:50, Graham Percival wrote: > LGTM Doesn't this require a regtest? V.
12 years, 11 months ago (2011-04-11 22:40:15 UTC) #2
Keith
Works well for me. There is already a regtest 'accidental-clef-change.ly' that you could just update. ...
12 years, 11 months ago (2011-04-12 03:39:17 UTC) #3
dak
On 2011/04/11 22:40:15, Valentin Villenave wrote: > Doesn't this require a regtest? The original bug ...
12 years, 11 months ago (2011-04-12 06:03:11 UTC) #4
Graham Percival
On Tue, Apr 12, 2011 at 06:03:11AM +0000, dak@gnu.org wrote: > I have been > ...
12 years, 11 months ago (2011-04-12 06:12:29 UTC) #5
dak
http://codereview.appspot.com/4384050/diff/1/scm/music-functions.scm File scm/music-functions.scm (right): http://codereview.appspot.com/4384050/diff/1/scm/music-functions.scm#newcode1007 scm/music-functions.scm:1007: (define (accidental-voided? alteration-def) On 2011/04/12 03:39:18, Keith wrote: > ...
12 years, 11 months ago (2011-04-12 07:18:31 UTC) #6
dak
On 2011/04/12 03:39:17, Keith wrote: > There is already a regtest 'accidental-clef-change.ly' that you could ...
12 years, 11 months ago (2011-04-12 12:55:01 UTC) #7
Keith
On 2011/04/12 12:55:01, dak wrote: > On 2011/04/12 03:39:17, Keith wrote: > > \key g\major ...
12 years, 11 months ago (2011-04-12 18:38:11 UTC) #8
Keith
On 2011/04/12 18:38:11, Keith wrote: > The '!' was not testing for anything, because ...
12 years, 11 months ago (2011-04-12 18:40:44 UTC) #9
dak
On 2011/04/12 18:38:11, Keith wrote: > On 2011/04/12 12:55:01, dak wrote: > > Only to ...
12 years, 11 months ago (2011-04-12 21:29:43 UTC) #10
Graham Percival (old account)
On 2011/04/12 12:55:01, dak wrote: > I intend to add an additional regtest file accidental-clef-change2.ly ...
12 years, 11 months ago (2011-04-13 07:15:36 UTC) #11
dak
> > \version "2.12.0" > \version "2.13.60" % because 2.12.0 gets the fis wrong Where ...
12 years, 11 months ago (2011-04-13 08:14:33 UTC) #12
Graham Percival (old account)
On 2011/04/13 08:14:33, dak wrote: > I think the version statement should reflect the version ...
12 years, 11 months ago (2011-04-13 09:40:08 UTC) #13
dak
12 years, 11 months ago (2011-04-13 10:22:28 UTC) #14
Pushed, taking comments into account.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b