Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(898)

Issue 4368049: Added new Pagesize definition to paper.scm (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 1 month ago by pkx166h
Modified:
13 years, 1 month ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Added new Pagesize definition to paper.scm Added 'c9landscape' to allow a very small @lilypond to be defined for examples that need to show footers, tagelines and the like, without having to 1.define the paper size inside the @lilypond (and so make the example more complicated than it need be for users. 2. Avoid unnecessary white space between the content and said, footers/taglines because of using a sizes. Chosen size is named c9landscape because the new papersize=X option added cannot use easily 'landscape mode nor do we want the output rotated 90 degrees. Keeping a standard ISO size (c9) means we don't have custom sizes defined in the scm.

Patch Set 1 #

Patch Set 2 : Second draft with .tely file removed from patch #

Patch Set 3 : Draft two including modified reg test file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M input/regression/lilypond-book/papersize-docs.tely View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M scm/paper.scm View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8
Graham Percival (old account)
I don't think we want to add papersize_test.tely to the repository. It's very important that ...
13 years, 1 month ago (2011-04-06 21:47:34 UTC) #1
Graham Percival (old account)
On 2011/04/06 21:47:34, Graham Percival wrote: > ... no wait, we do! hmm... I'll look ...
13 years, 1 month ago (2011-04-06 22:34:54 UTC) #2
pkx166h
On 2011/04/06 21:47:34, Graham Percival wrote: > I don't think we want to add papersize_test.tely ...
13 years, 1 month ago (2011-04-07 11:56:40 UTC) #3
pkx166h
On 2011/04/06 22:34:54, Graham Percival wrote: > On 2011/04/06 21:47:34, Graham Percival wrote: > > ...
13 years, 1 month ago (2011-04-07 12:10:14 UTC) #4
Graham Percival (old account)
On 2011/04/07 12:10:14, J_lowe wrote: > Graham, for now the c9landscape size is already included ...
13 years, 1 month ago (2011-04-07 22:12:00 UTC) #5
pkx166h
Thanks, done.
13 years, 1 month ago (2011-04-08 17:07:44 UTC) #6
Graham Percival (old account)
Looks great. At the moment, there's some huge space between the code and the example ...
13 years, 1 month ago (2011-04-09 02:51:41 UTC) #7
pkx166h
13 years, 1 month ago (2011-04-10 11:56:59 UTC) #8
Pushed as commit

71e0343fdf2a1936b07db0a5892155351c72d553
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b