Issue 4365051: Remove Redundant functions for arm memset optimizations

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4365051: Remove Redundant functions for arm memset optimizations (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by Shankar

Modified:
13 years, 8 months ago

Reviewers:
steve.mcintyre, DerekS, senorblanco, reed1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Unnecessary code duplication for returning arm/neon version of memset . Removed the redundant file and merged the functionality into opts_check_arm_neon.cpp which will return arm or neon version of memset based on build flag

Patch Set 1 #

Patch Set 2 : Dropped opts_check_arm_neon.cpp and merged functionality to opts_check_arm.cpp as per Steve advice #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -65 lines)			Patch
	D	src/opts/opts_check_arm.cpp	View	1	1 chunk	+52 lines, -20 lines	0 comments	Download
	M	src/opts/opts_check_arm_neon.cpp	View	1	1 chunk	+0 lines, -45 lines	0 comments	Download