Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(142)

Issue 4357054: Make SkFlate buffers statically sized (fixes Windows compile). (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 7 months ago by Steve VanDeBogart
Modified:
13 years, 7 months ago
Reviewers:
Chris Guillory, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Make SkFlate buffers statically sized (fixes Windows compile). Committed: http://code.google.com/p/skia/source/detail?r=1059

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10 lines) Patch
M include/core/SkFlate.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/core/SkFlate.cpp View 3 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 3
Steve VanDeBogart
13 years, 7 months ago (2011-04-05 19:51:01 UTC) #1
Chris Guillory
LGTM
13 years, 7 months ago (2011-04-05 19:53:16 UTC) #2
reed1
13 years, 7 months ago (2011-04-05 20:13:55 UTC) #3
LGTM

another pattern is to just use an enum in the private section

private:
    enum {
        kBufferSize = 1024
    };

I don't think its better in this case, since nothing in the class def needs to
know the size.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b