Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(766)

Issue 4355044: [PDF] Fix node count in page tree. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 5 months ago by Steve VanDeBogart
Modified:
13 years, 5 months ago
Reviewers:
Chris Guillory, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

[PDF] Fix node count in page tree. It should be the number of leaves below a given node, not the number of direct children in the node. Committed: http://code.google.com/p/skia/source/detail?r=1082

Patch Set 1 #

Patch Set 2 : Add comment describing method #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M src/pdf/SkPDFPage.cpp View 1 3 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 8
Steve VanDeBogart
13 years, 5 months ago (2011-04-02 02:05:29 UTC) #1
Steve VanDeBogart
13 years, 5 months ago (2011-04-05 17:21:42 UTC) #2
Steve VanDeBogart
ping
13 years, 5 months ago (2011-04-06 17:34:57 UTC) #3
ctguil
I can look at this when I get in today in the afternoon. Didn't understand ...
13 years, 5 months ago (2011-04-06 17:44:45 UTC) #4
reed1
I cannot speak to the pdf-logic of the change. Perhaps comment near the code would ...
13 years, 5 months ago (2011-04-06 17:44:45 UTC) #5
Steve VanDeBogart
On 2011/04/06 17:44:45, reed1 wrote: > I cannot speak to the pdf-logic of the change. ...
13 years, 5 months ago (2011-04-06 22:13:09 UTC) #6
reed1
LGTM, but I defer to Chris
13 years, 5 months ago (2011-04-07 13:12:41 UTC) #7
Chris Guillory
13 years, 5 months ago (2011-04-08 01:17:38 UTC) #8
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b