Issue 4354043: Move where compression enable/disable is done to make recompilation faster.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4354043: Move where compression enable/disable is done to make recompilation faster. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years ago by Steve VanDeBogart

Modified:
15 years ago

Reviewers:
Chris Guillory

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Description

Move where compression enable/disable is done to make recompilation faster. Committed: http://code.google.com/p/skia/source/detail?r=1035

Patch Set 1 #

Total comments: 1

Created: 15 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	Makefile	View		1 chunk	+0 lines, -2 lines	1 comment	Download
	M	src/core/SkFlate.cpp	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Chris Guillory

15 years ago (2011-04-01 18:26:33 UTC) #2

LGTM

http://codereview.appspot.com/4354043/diff/1/Makefile
File Makefile (left):

http://codereview.appspot.com/4354043/diff/1/Makefile#oldcode37
Makefile:37: DEFINES += -DSK_ZLIB_INCLUDE="<zlib.h>"
I don't believe SK_ZLIB_INCLUDE is currently defined for the gyp build. Is this
Makefile build deprecated?

Expand All Messages | Collapse All Messages