Issue 4352051: Fix dangling ptr when GrRenderTarget outlives its GrTexture representation

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4352051: Fix dangling ptr when GrRenderTarget outlives its GrTexture representation (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by bsalomon

Modified:
13 years, 9 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Total comments: 1

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+60 lines, -51 lines)			Patch
M	gpu/include/GrGLTexture.h	View	3 chunks	+2 lines, -5 lines	0 comments	Download
M	gpu/include/GrTexture.h	View	5 chunks	+52 lines, -19 lines	0 comments	Download
M	gpu/src/GrGLTexture.cpp	View	3 chunks	+2 lines, -16 lines	0 comments	Download
M	gpu/src/GrTexture.cpp	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	samplecode/SampleApp.cpp	View	1 chunk	+0 lines, -6 lines	1 comment	Download
M	vs/SampleApp/SampleApp.vcxproj	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	vs/SampleApp/SampleApp.vcxproj.filters	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bsalomon

Also moved management of GrTexture's GrRenderTarget ptr to base class from GL subclass. http://codereview.appspot.com/4352051/diff/1/samplecode/SampleApp.cpp File ...

13 years, 9 months ago (2011-04-05 21:11:47 UTC) #1

closed with r1061

Expand All Messages | Collapse All Messages