Issue 4351042: Fix unit test build for Mac

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4351042: Fix unit test build for Mac (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by bsalomon

Modified:
13 years, 8 months ago

Reviewers:
junov, reed1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -8 lines)			Patch
	M	gpu/src/gr_unittests.cpp	View		4 chunks	+7 lines, -8 lines	0 comments	Download

Total messages: 4

reed1

LGTM would it have worked if you had scoped the inner class? Foo::Inner

13 years, 8 months ago (2011-04-01 14:20:24 UTC) #2

bsalomon

13 years, 8 months ago (2011-04-01 17:07:19 UTC) #4

closed with r1034

On 2011/04/01 14:21:56, junov wrote:
> Good to know.  LGTM