Issue 4331053: Add src/core include for pdf project.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4331053: Add src/core include for pdf project. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by Chris Guillory

Modified:
13 years, 7 months ago

Reviewers:
Steve VanDeBogart

CC:
skia-review_googlegroups.com, bsalomon

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Add src/core include for pdf project. Committed: http://code.google.com/p/skia/source/detail?r=1032

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	gyp/skia.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 3

Chris Guillory

This fixes building the pdf project for win and linux. Bulding on mac succeeds without ...

13 years, 7 months ago (2011-03-31 22:54:53 UTC) #1

bsalomon

13 years, 7 months ago (2011-04-01 13:12:01 UTC) #3

LGTM. too.

On Thu, Mar 31, 2011 at 7:03 PM, <vandebo@chromium.org> wrote:

> LGTM
>
>
> http://codereview.appspot.com/4331053/
>