Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1403)

Issue 4327042: Use gtk_status_icon_set_name() only if it is available. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years ago by Daiki Ueno
Modified:
13 years ago
Reviewers:
shawn.p.huang, Peng
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

Use gtk_status_icon_set_name() only if it is available. gtk_status_icon_set_name() is not exported to python through pygtk2 <= 2.17, which is the version from Debian sid and Fedora 14. >>> import gtk >>> gtk.pygtk_version (2, 17, 0) >>> hasattr(gtk.StatusIcon, 'set_name') False This patch checks the availability. BUG=none TEST=manual

Patch Set 1 #

Patch Set 2 : fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M ui/gtk/panel.py View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 3
Daiki Ueno
13 years ago (2011-03-29 06:52:15 UTC) #1
Peng
On 2011/03/29 06:52:15, Daiki Ueno wrote: LGTM
13 years ago (2011-03-29 13:36:15 UTC) #2
Daiki Ueno
13 years ago (2011-03-30 02:40:00 UTC) #3
On 2011/03/29 13:36:15, Peng wrote:
> On 2011/03/29 06:52:15, Daiki Ueno wrote:
> 
> LGTM

Thanks for the review and commit.  Closing.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b