Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(896)

Issue 4325048: Support eglCreatePbufferFromClientBuffer (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years ago by John Bauman
Modified:
12 years, 10 months ago
Reviewers:
dgkoch, apatrick1
CC:
angleproject-review_googlegroups.com
Base URL:
https://angleproject.googlecode.com/svn/trunk
Visibility:
Public.

Description

Add support for eglCreatePbufferFromClientBuffer, taking as input a D3D share handle corresponding to the enum EGL_D3D_TEXTURE_2D_SHARE_HANDLE_ANGLE. No spec as of yet, but it does the obvious thing. BUG=129 TEST= Committed: http://code.google.com/p/angleproject/source/detail?r=650

Patch Set 1 #

Total comments: 11

Patch Set 2 : add extension text, make error work #

Total comments: 2

Patch Set 3 : fix extension text issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+552 lines, -437 lines) Patch
A extensions/EGL_ANGLE_share_handle_client_buffer.txt View 1 2 1 chunk +94 lines, -0 lines 0 comments Download
M src/libEGL/Display.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/libEGL/Display.cpp View 1 2 2 chunks +16 lines, -2 lines 0 comments Download
M src/libEGL/Surface.h View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M src/libEGL/Surface.cpp View 1 2 1 chunk +431 lines, -428 lines 0 comments Download
M src/libEGL/libEGL.cpp View 1 2 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 10
John Bauman
Basic implementation of eglCreatePbufferFromClient - mostly involves moving code around.
13 years ago (2011-03-31 20:19:28 UTC) #1
apatrick1
Sorry that took slow long. I'm recovering from a cold. Here's some initial feedback, really ...
12 years, 12 months ago (2011-04-04 04:30:35 UTC) #2
John Bauman
http://codereview.appspot.com/4325048/diff/1/src/libEGL/Display.cpp File src/libEGL/Display.cpp (right): http://codereview.appspot.com/4325048/diff/1/src/libEGL/Display.cpp#newcode416 src/libEGL/Display.cpp:416: EGLSurface Display::createOffscreenSurface(EGLConfig config, HANDLE shareHandle, const EGLint *attribList) On ...
12 years, 12 months ago (2011-04-04 17:56:31 UTC) #3
apatrick1
LGTM but handing over sign-off to Daniel. http://codereview.appspot.com/4325048/diff/1/src/libEGL/Surface.cpp File src/libEGL/Surface.cpp (right): http://codereview.appspot.com/4325048/diff/1/src/libEGL/Surface.cpp#newcode46 src/libEGL/Surface.cpp:46: : mDisplay(display), ...
12 years, 12 months ago (2011-04-05 18:29:50 UTC) #4
dgkoch
Haven't done a full review yet, but here are my preliminary comments. 1) would like ...
12 years, 12 months ago (2011-04-06 20:14:35 UTC) #5
dgkoch
On 2011/04/06 20:14:35, dgkoch wrote: > Haven't done a full review yet, but here are ...
12 years, 11 months ago (2011-04-19 12:50:40 UTC) #6
John Bauman
Add extension text to patch. Also, add an initialize method to the surface to make ...
12 years, 11 months ago (2011-05-03 13:21:20 UTC) #7
dgkoch
A few minor nits about the extension text, but otherwise LGTM. http://codereview.appspot.com/4325048/diff/9001/extensions/EGL_ANGLE_share_handle_client_buffer.txt File extensions/EGL_ANGLE_share_handle_client_buffer.txt (right): ...
12 years, 11 months ago (2011-05-03 19:19:09 UTC) #8
John Bauman
Thanks, here's a patch with extension text that hopefully fixes all the issues.
12 years, 10 months ago (2011-05-10 19:32:23 UTC) #9
dgkoch
12 years, 10 months ago (2011-05-12 04:39:25 UTC) #10
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b