On 2011/03/30 18:42:14, bsalomon wrote: > Why are the SK_APIs on SkPDFDocument's functions rather than ...
13 years, 5 months ago
(2011-03-30 18:56:38 UTC)
#3
On 2011/03/30 18:42:14, bsalomon wrote:
> Why are the SK_APIs on SkPDFDocument's functions rather than the class?
> Otherwise LGTM.
>
> On 2011/03/30 18:32:14, Chris Guillory wrote:
When exporting classes with template data members VS needs exported instantiated
template definitions for linking. This seems more intrusive than exporting the
needed class members.
Similar to: http://support.microsoft.com/kb/168958
I did this previously here:
http://codereview.chromium.org/6674050/diff/1/skia/ext/convolver.h
makes sense to me. LGTM On 2011/03/30 18:56:38, Chris Guillory wrote: > On 2011/03/30 18:42:14, ...
13 years, 5 months ago
(2011-03-30 20:04:20 UTC)
#4
makes sense to me. LGTM
On 2011/03/30 18:56:38, Chris Guillory wrote:
> On 2011/03/30 18:42:14, bsalomon wrote:
> > Why are the SK_APIs on SkPDFDocument's functions rather than the class?
> > Otherwise LGTM.
> >
> > On 2011/03/30 18:32:14, Chris Guillory wrote:
> When exporting classes with template data members VS needs exported
instantiated
> template definitions for linking. This seems more intrusive than exporting the
> needed class members.
> Similar to: http://support.microsoft.com/kb/168958
>
> I did this previously here:
> http://codereview.chromium.org/6674050/diff/1/skia/ext/convolver.h
Issue 4324042: Additional SK_API annotations needed for print preview on windows.
(Closed)
Created 13 years, 5 months ago by Chris Guillory
Modified 13 years, 5 months ago
Reviewers: bsalomon
Base URL: http://skia.googlecode.com/svn/trunk/
Comments: 0