Issue 4324042: Additional SK_API annotations needed for print preview on windows.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4324042: Additional SK_API annotations needed for print preview on windows. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by Chris Guillory

Modified:
13 years, 8 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com, reed1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Additional SK_API annotations needed for print preview on windows. Committed: http://code.google.com/p/skia/source/detail?r=1022

Patch Set 1 #

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -7 lines)			Patch
M	include/core/SkStream.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	include/pdf/SkPDFCatalog.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	include/pdf/SkPDFDocument.h	View	1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bsalomon

Why are the SK_APIs on SkPDFDocument's functions rather than the class? Otherwise LGTM. On 2011/03/30 ...

13 years, 8 months ago (2011-03-30 18:42:14 UTC) #2

Chris Guillory

On 2011/03/30 18:42:14, bsalomon wrote: > Why are the SK_APIs on SkPDFDocument's functions rather than ...

13 years, 8 months ago (2011-03-30 18:56:38 UTC) #3

bsalomon

13 years, 8 months ago (2011-03-30 20:04:20 UTC) #4

makes sense to me. LGTM

On 2011/03/30 18:56:38, Chris Guillory wrote:
> On 2011/03/30 18:42:14, bsalomon wrote:
> > Why are the SK_APIs on SkPDFDocument's functions rather than the class?
> > Otherwise LGTM.
> > 
> > On 2011/03/30 18:32:14, Chris Guillory wrote:
> When exporting classes with template data members VS needs exported
instantiated
> template definitions for linking. This seems more intrusive than exporting the
> needed class members. 
> Similar to: http://support.microsoft.com/kb/168958
> 
> I did this previously here:
> http://codereview.chromium.org/6674050/diff/1/skia/ext/convolver.h

Expand All Messages | Collapse All Messages