Issue 4323043: Fix GrGpu ref leak

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4323043: Fix GrGpu ref leak (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 4 months ago by bsalomon

Modified:
13 years, 4 months ago

Reviewers:
reed1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Created: 13 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+84 lines, -50 lines)			Patch
M	gpu/src/GrBufferAllocPool.h	View		5 chunks	+39 lines, -33 lines	0 comments	Download
M	gpu/src/GrBufferAllocPool.cpp	View	1	2 chunks	+14 lines, -3 lines	0 comments	Download
M	gpu/src/GrGpu.cpp	View		6 chunks	+10 lines, -8 lines	0 comments	Download
M	samplecode/SampleApp.cpp	View		4 chunks	+13 lines, -6 lines	0 comments	Download
M	xcode/gpu/gpu.xcodeproj/project.pbxproj	View		5 chunks	+8 lines, -0 lines	0 comments	Download

Total messages: 2

reed1

13 years, 4 months ago (2011-03-29 20:29:50 UTC) #2

I hate it (having a ptr that we don't own) but I don't see a diff solution right
now.

LGTM