Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1162)

Issue 4313053: Improve the SkAdvancedTypefaceMetrics interface w.r.t. vertical advances. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 3 months ago by Steve VanDeBogart
Modified:
13 years, 3 months ago
Reviewers:
Chris Guillory, reed1
CC:
skia-review_googlegroups.com, bsalomon, zmo
Base URL:
https://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Improve the SkAdvancedTypefaceMetrics interface w.r.t. vertical advances. Add a template function to type safe-combine bits of a bit field. Committed: http://code.google.com/p/skia/source/detail?r=1020

Patch Set 1 #

Total comments: 5

Patch Set 2 : Address comments #

Patch Set 3 : Rename bit combiner #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -35 lines) Patch
M include/core/SkAdvancedTypefaceMetrics.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M include/core/SkFontHost.h View 1 1 chunk +4 lines, -4 lines 0 comments Download
M include/core/SkTypeface.h View 1 2 chunks +7 lines, -2 lines 0 comments Download
M include/core/SkTypes.h View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M src/core/SkTypeface.cpp View 1 2 chunks +11 lines, -1 line 0 comments Download
M src/pdf/SkPDFFont.cpp View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M src/ports/SkFontHost_FONTPATH.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/ports/SkFontHost_FreeType.cpp View 1 4 chunks +25 lines, -20 lines 0 comments Download
M src/ports/SkFontHost_mac_atsui.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/ports/SkFontHost_mac_coretext.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/ports/SkFontHost_none.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/ports/SkFontHost_simple.cpp View 1 1 chunk +2 lines, -1 line 0 comments Download
M src/ports/SkFontHost_win.cpp View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4
Steve VanDeBogart
13 years, 3 months ago (2011-03-28 21:48:57 UTC) #1
Chris Guillory
LGTM with other comments from Mike. http://codereview.appspot.com/4313053/diff/1/src/ports/SkFontHost_FreeType.cpp File src/ports/SkFontHost_FreeType.cpp (right): http://codereview.appspot.com/4313053/diff/1/src/ports/SkFontHost_FreeType.cpp#newcode465 src/ports/SkFontHost_FreeType.cpp:465: if (perGlyphInfo | ...
13 years, 3 months ago (2011-03-28 22:20:47 UTC) #2
Steve VanDeBogart
+bsalomon in case you have any thoughts on SkBitFieldCombine http://codereview.appspot.com/4313053/diff/1/src/ports/SkFontHost_FreeType.cpp File src/ports/SkFontHost_FreeType.cpp (right): http://codereview.appspot.com/4313053/diff/1/src/ports/SkFontHost_FreeType.cpp#newcode465 src/ports/SkFontHost_FreeType.cpp:465: ...
13 years, 3 months ago (2011-03-28 23:10:50 UTC) #3
reed1
13 years, 3 months ago (2011-03-30 18:28:15 UTC) #4
SkTBitOR ?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b