Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(396)

Issue 4311041: obliterate DIGIT token class (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 1 month ago by dak
Modified:
12 years, 7 months ago
Reviewers:
Graham Percival (old account), reinhold, carl.d.sorensen, c_sorensen
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

The current patch passes regtests and removes the DIGIT token class. It is intended for merging after review. The choice that has been taken is that an assignment x=-3 will not be considered as a fingering, but rather as a negative number. After loading Documentation/snippets/creating-double-digit-fingerings.ly, you can use x=-\finger 3 to do this instead. The \finger music function should likely be part of Lilypond rather than just example code. But that's a different issue. I am not actually sure what the previous behavior would have been: the DIGIT stuff was rather inscrutable.

Patch Set 1 #

Patch Set 2 : -4 in assignments is not fingering, but number. Passes regtests AFAICT. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -26 lines) Patch
M lily/lexer.ll View 1 2 chunks +0 lines, -9 lines 0 comments Download
M lily/parser.yy View 1 10 chunks +21 lines, -17 lines 0 comments Download

Messages

Total messages: 6
Carl
LGTM. This was a clever way to solve things. Thanks, David!
12 years, 7 months ago (2011-09-11 12:49:46 UTC) #1
dak
Carl.D.Sorensen@gmail.com writes: > LGTM. > > This was a clever way to solve things. Thanks, ...
12 years, 7 months ago (2011-09-11 13:10:07 UTC) #2
c_sorensen
On 9/11/11 7:09 AM, "David Kastrup" <dak@gnu.org> wrote: > Carl.D.Sorensen@gmail.com writes: > >> LGTM. >> ...
12 years, 7 months ago (2011-09-11 13:18:45 UTC) #3
Graham Percival (old account)
sorry, it's a bit unclear if this is a real patch or not, due to ...
12 years, 7 months ago (2011-09-11 14:27:35 UTC) #4
reinhold_kainhofer.com
Am Sunday, 11. September 2011, 16:27:35 schrieb percival.music.ca@gmail.com: > sorry, it's a bit unclear if ...
12 years, 7 months ago (2011-09-11 14:36:23 UTC) #5
dak
12 years, 7 months ago (2011-09-11 14:56:43 UTC) #6
On 2011/09/11 14:36:23, reinhold_kainhofer.com wrote:
> Am Sunday, 11. September 2011, 16:27:35 schrieb percival.music.ca@gmail.com:
> > sorry, it's a bit unclear if this is a real patch or not, due to
> > Reitveld screwed-up-ness.
> > 
> > The top of this page states this:
> > > Do _not_, I repeat, do _not_ merge.
> > 
> > I think that's left-over from your previous patch, but I don't know how
> > to force Rietveld to only display the commit message from the second
> > patch.  (if that's even possible)
> 
> Simply go to "Edit Issue" and enter the new description...
> AFAIK, this can't be done automatically with git-cl

Description has been changed.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b