Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(768)

Issue 4298049: Add asynchronous InputContext.IsEnabled and InputContext.GetEngine APIs. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years ago by Yusuke Sato
Modified:
13 years ago
Reviewers:
shawn.p.huang
CC:
satorux
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

Add asynchronous InputContext.IsEnabled and InputContext.GetEngine APIs. * Added asynchronous InputContext.IsEnabled and InputContext.GetEngine APIs. Now all InputContext IPCs can be async. * Added comments to src/ibusinputcontext.h. * Moved input context tests from ibus-bus.c to ibus-inputcontext.c (new file), and fixed flaky tests. * Fixed typos in bus/. BUG=http://code.google.com/p/ibus/issues/detail?id=1215 TEST=ran the new test

Patch Set 1 #

Total comments: 10

Patch Set 2 : review fix #

Total comments: 3

Patch Set 3 : review fix2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+437 lines, -72 lines) Patch
M bus/ibusimpl.c View 1 chunk +4 lines, -1 line 0 comments Download
M bus/inputcontext.c View 1 chunk +1 line, -1 line 0 comments Download
M src/ibusinputcontext.h View 1 2 11 chunks +82 lines, -8 lines 0 comments Download
M src/ibusinputcontext.c View 1 5 chunks +84 lines, -5 lines 0 comments Download
M src/tests/.gitignore View 1 chunk +1 line, -0 lines 0 comments Download
M src/tests/Makefile.am View 2 chunks +4 lines, -0 lines 0 comments Download
M src/tests/ibus-bus.c View 3 chunks +3 lines, -57 lines 0 comments Download
A src/tests/ibus-inputcontext.c View 1 1 chunk +258 lines, -0 lines 0 comments Download

Messages

Total messages: 5
Yusuke Sato
Please review this instead of http://codereview.appspot.com/4275048/.
13 years ago (2011-03-18 14:08:55 UTC) #1
Peng
http://codereview.appspot.com/4298049/diff/1/src/ibusinputcontext.h File src/ibusinputcontext.h (right): http://codereview.appspot.com/4298049/diff/1/src/ibusinputcontext.h#newcode364 src/ibusinputcontext.h:364: * @context: An IBusInputContext. Add #. #IBusInputContext. http://codereview.appspot.com/4298049/diff/1/src/ibusinputcontext.h#newcode366 src/ibusinputcontext.h:366: ...
13 years ago (2011-03-18 15:40:40 UTC) #2
Yusuke Sato
Thanks for the review. Please take another look. http://codereview.appspot.com/4298049/diff/1/src/ibusinputcontext.h File src/ibusinputcontext.h (right): http://codereview.appspot.com/4298049/diff/1/src/ibusinputcontext.h#newcode364 src/ibusinputcontext.h:364: * ...
13 years ago (2011-03-21 05:17:29 UTC) #3
Peng
LGTM http://codereview.appspot.com/4298049/diff/3002/src/ibusinputcontext.h File src/ibusinputcontext.h (right): http://codereview.appspot.com/4298049/diff/3002/src/ibusinputcontext.h#newcode366 src/ibusinputcontext.h:366: * @cancellable: A GCancellable or %NULL. #GCancellable http://codereview.appspot.com/4298049/diff/3002/src/tests/ibus-inputcontext.c ...
13 years ago (2011-03-21 14:06:43 UTC) #4
Yusuke Sato
13 years ago (2011-03-22 05:09:22 UTC) #5
submitting

http://codereview.appspot.com/4298049/diff/3002/src/ibusinputcontext.h
File src/ibusinputcontext.h (right):

http://codereview.appspot.com/4298049/diff/3002/src/ibusinputcontext.h#newcod...
src/ibusinputcontext.h:366: * @cancellable: A GCancellable or %NULL.
On 2011/03/21 14:06:43, Peng wrote:
> #GCancellable

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b