Close loopholes in note-collision logic

lily/note-collision.cc: handle more dot situations

Patch sets 1--5 were for issue 1174, now done.

Patch set 6-- are for issue 2200.
Makes it feasible to set DotColumns separately in each voice.

[Keith, 2011-03-19 03:50:42]

http://codereview.appspot.com/4293054/diff/7001/lily/note-collision.cc
File lily/note-collision.cc (right):

http://codereview.appspot.com/4293054/diff/7001/lily/note-collision.cc#newcod...
lily/note-collision.cc:331: FIXME:
if I understand this comment, the problem seems to have been fixed.  Can anyone
confirm or deny?

[MikeSol, 2011-03-19 13:18:07]

LGTM

[Keith, 2011-04-26 06:00:21]

http://codereview.appspot.com/4293054/diff/7001/input/regression/collision-do...
File input/regression/collision-dots-move.ly (right):

http://codereview.appspot.com/4293054/diff/7001/input/regression/collision-do...
input/regression/collision-dots-move.ly:4: texidoc = "If dotted note heads must
remain on the left side,
restore whitespace

http://codereview.appspot.com/4293054/diff/7001/lily/note-collision.cc
File lily/note-collision.cc (right):

http://codereview.appspot.com/4293054/diff/7001/lily/note-collision.cc#newcod...
lily/note-collision.cc:323: else if (shift_amount > 1e-6
we do not want the test on shift_amount (inherited from old code) because in the
case of merged heads we do want dots to avoid any heads on the unusual side of
the upstem

[pkx166h, 2011-07-31 19:00:41]

Passes Make and reg tests

http://code.google.com/p/lilypond/issues/detail?id=1792#c1

[Keith, 2012-01-08 04:15:03]

http://codereview.appspot.com/4293054/diff/21002/lily/note-collision.cc
File lily/note-collision.cc (right):

http://codereview.appspot.com/4293054/diff/21002/lily/note-collision.cc#newco...
lily/note-collision.cc:315: && Rhythmic_head::dot_count (head_up))
Probably wise to remove the condition on the dot_count to the right, in any
case.

http://codereview.appspot.com/4293054/diff/21002/ly/engraver-init.ly
File ly/engraver-init.ly (right):

http://codereview.appspot.com/4293054/diff/21002/ly/engraver-init.ly#newcode228
ly/engraver-init.ly:228: \consists "Dot_column_engraver"
Having the Voice make its own dot columns creates a difficulty when colliding
chords require dots to move vertically: << <e' b'>4. \\ g'4. >>

The code in note-collision.cc is negotiating between Voices, so it would need to
be smarter.