code review 4291069: http: modified perl cgi test to remove newline from env...

src/pkg/http/cgi/testdata/test.cgi

 #!/usr/bin/perl
 # Copyright 2011 The Go Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style
 # license that can be found in the LICENSE file.
 #
 # Test script run as a child process under cgi_test.go
 
 use strict;
 use CGI;
 
@@ skipping 12 matching lines @@
 $p->("X-Test-Header: X-Test-Value");
 $p->("");
 
 print "test=Hello CGI\n";
 
 foreach my $k (sort keys %$params) {
   print "param-$k=$params->{$k}\n";
 }
 
 foreach my $k (sort keys %ENV) {
-  print "env-$k=$ENV{$k}\n";
+  print "env-$k=".do { (my $new_env = $ENV{$k}) =~ s/[\n\r]//g; $new_env } . "\n";

[bradfitz, 2011/03/25 14:56:35]

Thanks for the fix!

I'd prefer if we didn't play Perl Golf here.  Could you burn a few more lines
here for future maintainers who might not know Perl as well?

my $clean_env = $ENV{$k};
$clean_env =~ s/[\n\r]//g;
print "env-$k=$clean_env\n";

 }