Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(425)

Issue 4290060: [Skia GPU] Remove redundant texure mapping flags in GrGLDefines.h

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 7 months ago by weiwei.li
Modified:
13 years, 7 months ago
Base URL:
http://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Some texture flags are re-defined twice in GrGLDefines.h, especially in texture mapping section, these will make confusion. The CL will comment out redundant texture flags to make codes more professional.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
GrGLDefines.h View 3 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 3
weiwei.li
13 years, 7 months ago (2011-03-22 06:40:33 UTC) #1
bsalomon
Thanks for catching this! LGTM. I'll check it in. On 2011/03/22 06:40:33, weiwei.li wrote:
13 years, 7 months ago (2011-03-22 13:03:52 UTC) #2
twiz1
13 years, 7 months ago (2011-03-22 15:41:03 UTC) #3
On 2011/03/22 13:03:52, bsalomon wrote:
> Thanks for catching this! LGTM. I'll check it in.
> 
> On 2011/03/22 06:40:33, weiwei.li wrote:

LGTM.

Thanks for making this change, Weiwei  Most of this code was taken straight from
either the MESA gl.h headers or the chromium GLES2 gl.h headers.

Jeff
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b