Issue 4290060: [Skia GPU] Remove redundant texure mapping flags in GrGLDefines.h

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4290060: [Skia GPU] Remove redundant texure mapping flags in GrGLDefines.h

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by weiwei.li

Modified:
13 years, 9 months ago

Reviewers:
bsalomon, Stephen White, twiz1, reed1

Base URL:
http://skia.googlecode.com/svn/trunk

Visibility:
Public.

Description

Some texture flags are re-defined twice in GrGLDefines.h, especially in texture mapping section, these will make confusion. The CL will comment out redundant texture flags to make codes more professional.

Patch Set 1 #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -10 lines)			Patch
		GrGLDefines.h	View		3 chunks	+10 lines, -10 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bsalomon

Thanks for catching this! LGTM. I'll check it in. On 2011/03/22 06:40:33, weiwei.li wrote:

13 years, 9 months ago (2011-03-22 13:03:52 UTC) #2

twiz1

13 years, 9 months ago (2011-03-22 15:41:03 UTC) #3

On 2011/03/22 13:03:52, bsalomon wrote:
> Thanks for catching this! LGTM. I'll check it in.
> 
> On 2011/03/22 06:40:33, weiwei.li wrote:

LGTM.

Thanks for making this change, Weiwei  Most of this code was taken straight from
either the MESA gl.h headers or the chromium GLES2 gl.h headers.

Jeff

Expand All Messages | Collapse All Messages