Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1199)

Issue 4290053: Refine document and coding style in ibusbus.[ch] and trim some private structs and api from document (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years ago by Peng
Modified:
13 years ago
Reviewers:
Yusuke Sato
CC:
satorux
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

Refine document and coding style in ibusbus.[ch] and trim some private structs and api from document BUG=none TEST=make

Patch Set 1 #

Patch Set 2 : Update #

Patch Set 3 : Update #

Patch Set 4 : Update #

Total comments: 1

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+403 lines, -353 lines) Patch
M .gitignore View 3 chunks +0 lines, -3 lines 0 comments Download
M docs/reference/ibus/.gitignore View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M docs/reference/ibus/Makefile.am View 1 2 1 chunk +3 lines, -8 lines 0 comments Download
A docs/reference/ibus/trim.sed View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M src/.gitignore View 1 chunk +0 lines, -1 line 0 comments Download
M src/ibusbus.h View 1 2 3 4 16 chunks +382 lines, -333 lines 0 comments Download
M src/ibusbus.c View 1 2 3 4 4 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 2
Peng
13 years ago (2011-03-16 21:41:00 UTC) #1
Yusuke Sato
13 years ago (2011-03-17 11:36:38 UTC) #2
LGTM

http://codereview.appspot.com/4290053/diff/2002/src/ibusbus.c
File src/ibusbus.c (right):

http://codereview.appspot.com/4290053/diff/2002/src/ibusbus.c#newcode130
src/ibusbus.c:130: * Emitted when #IBusBus lost is disconnected from
ibus-daemon.
not sure, but s/lost// ??
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b