Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(356)

Issue 4288047: Correct GL ES 1.0 build breaks. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 8 months ago by twiz1
Modified:
13 years, 8 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Correction of GLES build issue introduced by in revision: http://code.google.com/p/skia/source/detail?r=937 Issue: http://code.google.com/p/skia/issues/detail?id=174 Committed: http://code.google.com/p/skia/source/detail?r=940

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M gpu/src/GrGLInterface.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
twiz1
Hi Brian, I had made a strong effort to cover as many platforms as I ...
13 years, 8 months ago (2011-03-15 15:58:46 UTC) #1
twiz1
+ skia-review On 2011/03/15 15:58:46, twiz1 wrote: > Hi Brian, > > I had made ...
13 years, 8 months ago (2011-03-15 16:00:09 UTC) #2
bsalomon
13 years, 8 months ago (2011-03-15 16:10:10 UTC) #3
Hi Jeff, thanks for fixing this issue! As far as I know this is sufficient.
Unfortunately, we don't have a test environment for ES 1.1 :( 

We previously used the ipad demo app. I know Mike has talked about reviving
that. Also, Derek Sollenberger has expressed interest in getting the SampleApp
running on Android. So one of these should materialize soon.

In the meantime I'll send word out to an external developer that we know is
using ES 1.1 about this issue and hopefully he can let us know if it works for
him after this CL.

LGTM.

On 2011/03/15 16:00:09, twiz1 wrote:
> + skia-review
> 
> On 2011/03/15 15:58:46, twiz1 wrote:
> > Hi Brian, 
> > 
> > I had made a strong effort to cover as many platforms as I could with my
> > previous change.  Should this be sufficient to correct the problem on ES 1.0
> > devices?
> > 
> > What is a good build environment that pulls in ES 1.0?
> > 
> > Thanks,
> > 
> > Jeff
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b