Issue 4287077: glGetProgramiv(GL_ACTIVE_UNIFORM_MAX_LENGTH) should count an extra 3 if uniform is an array becau...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4287077: glGetProgramiv(GL_ACTIVE_UNIFORM_MAX_LENGTH) should count an extra 3 if uniform is an array becau... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 5 months ago by Zhenyao Mo

Modified:
14 years, 5 months ago

Reviewers:
kbr1

CC:
angleproject-review_googlegroups.com, VangelisK, apatrick1, dgkoch, nicolas

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

Description

glGetProgramiv(GL_ACTIVE_UNIFORM_MAX_LENGTH) should count an extra 3 if uniform is an array because "[0]" is appended. BUG=135 TEST=the attached htm in the bug runs ok Committed: http://code.google.com/p/angleproject/source/detail?r=592

Patch Set 1 #

Created: 14 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	src/libGLESv2/Program.cpp	View		1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

kbr1

14 years, 5 months ago (2011-03-24 21:10:23 UTC) #2

LGTM but it looks like there is an ambiguity in the existing code about uniforms
of length 1. It looks like we will return just the base name for those uniforms,
rather than "name[0]".

Perhaps we should file another bug about this, but this one should definitely be
fixed.

Expand All Messages | Collapse All Messages