Add support for GL_CHROMIUM_framebuffer_multisample to Gr

[bsalomon, 2011-03-22 21:47:28]

I tested this in chrome by forcing layers to have Skia-created layers to have AA
enabled. It worked once I made this chrome change (for windows):
http://codereview.chromium.org/6724004/

http://codereview.appspot.com/4287072/diff/2001/gpu/src/GrGLInterface.cpp
File gpu/src/GrGLInterface.cpp (right):

http://codereview.appspot.com/4287072/diff/2001/gpu/src/GrGLInterface.cpp#new...
gpu/src/GrGLInterface.cpp:232:
GR_GL_GET_PROC_SUFFIX(RenderbufferStorageMultisample, APPLE);
This one was missing. We aren't testing on IOS anymore
so this went undetected. :(

http://codereview.appspot.com/4287072/diff/2001/gpu/src/GrGpuGL.cpp
File gpu/src/GrGpuGL.cpp (right):

http://codereview.appspot.com/4287072/diff/2001/gpu/src/GrGpuGL.cpp#newcode1348
gpu/src/GrGpuGL.cpp:1348: // these respect the scissor during the blit, so
disable it.
We should have been doing this all along for the EXT extension.

[twiz1, 2011-03-22 22:22:53]

LGTM.

http://codereview.appspot.com/4287072/diff/2001/gpu/src/GrGLInterface.cpp
File gpu/src/GrGLInterface.cpp (right):

http://codereview.appspot.com/4287072/diff/2001/gpu/src/GrGLInterface.cpp#new...
gpu/src/GrGLInterface.cpp:220: if (!msaaFound &&
Do you need to check !msaaFound here?  I guess it doesn't detract too much from
clarity, but it's not needed for the first 'probe'.

http://codereview.appspot.com/4287072/diff/2001/gpu/src/GrGLInterface.cpp#new...
gpu/src/GrGLInterface.cpp:232:
GR_GL_GET_PROC_SUFFIX(RenderbufferStorageMultisample, APPLE);
On 2011/03/22 21:47:29, bsalomon wrote:
> This one was missing. We aren't testing on IOS anymore
> so this went undetected. :(

Thanks for catching that and making the change.

[bsalomon, 2011-03-23 13:49:49]

On 2011/03/22 22:22:53, twiz1 wrote:
> LGTM.
> 
> http://codereview.appspot.com/4287072/diff/2001/gpu/src/GrGLInterface.cpp
> File gpu/src/GrGLInterface.cpp (right):
> 
>
http://codereview.appspot.com/4287072/diff/2001/gpu/src/GrGLInterface.cpp#new...
> gpu/src/GrGLInterface.cpp:220: if (!msaaFound &&
> Do you need to check !msaaFound here?  I guess it doesn't detract too much
from
> clarity, but it's not needed for the first 'probe'.

Not really. I was just thinking that someone might add another higher-precedence
extension above the CHROMIUM one. This way they wouldn't have to remember to add
the check. Really its moot, though, since were going to remove the generic
platform code anyway.

> 
>
http://codereview.appspot.com/4287072/diff/2001/gpu/src/GrGLInterface.cpp#new...
> gpu/src/GrGLInterface.cpp:232:
> GR_GL_GET_PROC_SUFFIX(RenderbufferStorageMultisample, APPLE);
> On 2011/03/22 21:47:29, bsalomon wrote:
> > This one was missing. We aren't testing on IOS anymore
> > so this went undetected. :(
> 
> Thanks for catching that and making the change.

No prob. It was probably already missing before your change but just worked
because on IOS the GR_GL macro devolved down to just calling the platform GL
functions without a funciont pointer.