Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(915)

Issue 4287049: Fix issue of InputContext.SetEngine. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years ago by Peng
Modified:
13 years ago
Reviewers:
Yusuke Sato, fujiwara
CC:
satorux
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

Fix issue of InputContext.SetEngine. InputContext.SetEngine returns error sometimes, because "request-engine" signal handler calls an async function to set the engine of the context. So checking context->engine != NULL just after emiting "request-engine" signal is not correct. BUG=none TEST=Linux desktop

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -43 lines) Patch
M bus/ibusimpl.c View 7 chunks +47 lines, -21 lines 1 comment Download
M bus/inputcontext.c View 6 chunks +82 lines, -15 lines 0 comments Download
M bus/marshalers.list View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 2
Peng
13 years ago (2011-03-15 15:03:31 UTC) #1
Yusuke Sato
13 years ago (2011-03-16 05:28:11 UTC) #2
LGTM

http://codereview.appspot.com/4287049/diff/1/bus/ibusimpl.c
File bus/ibusimpl.c (right):

http://codereview.appspot.com/4287049/diff/1/bus/ibusimpl.c#newcode982
bus/ibusimpl.c:982: _context_request_engine_cb (BusInputContext *context,
please rename the function name. "request engine cb" is now misleading. I think.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b