Issue 4282056: Initial GYP generated projects/makefiles

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4282056: Initial GYP generated projects/makefiles (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by bsalomon

Modified:
13 years, 8 months ago

Reviewers:
Leon, reed1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1698 lines, -267 lines)			Patch
A	gyp/skia.gyp	View	1 chunk	+1430 lines, -0 lines	0 comments	Download
M	include/core/SkScalar.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	include/views/SkOSWindow_Unix.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	include/views/SkWidgetViews.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/animator/SkDisplayXMLParser.cpp	View	3 chunks	+10 lines, -2 lines	0 comments	Download
M	src/ports/SkFontHost_win.cpp	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/svg/SkSVGPaintState.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/utils/SkOSFile.cpp	View	5 chunks	+11 lines, -10 lines	0 comments	Download
D	src/utils/mac/skia_mac.cp	View	1 chunk	+0 lines, -43 lines	0 comments	Download
A	src/utils/mac/skia_mac.cpp	View	1 chunk	+43 lines, -0 lines	0 comments	Download
M	src/utils/unix/SkOSWindow_Unix.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/utils/win/SkOSWindow_Win.cpp	View	5 chunks	+11 lines, -6 lines	0 comments	Download
A	src/utils/win/skia_win.cpp	View	1 chunk	+167 lines, -0 lines	0 comments	Download
M	src/views/SkListWidget.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/views/SkProgressView.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	unix_test_app/main.cpp	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	vs/SampleApp/SampleApp.vcxproj	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	vs/SampleApp/SampleApp.vcxproj.filters	View	2 chunks	+2 lines, -1 line	0 comments	Download
D	vs/SampleApp/skia_win.cpp	View	1 chunk	+0 lines, -190 lines	0 comments	Download
M	xcode/sampleapp/SampleApp.xcodeproj/project.pbxproj	View	4 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

bsalomon

This adds a GYP that can generate projects for Mac, Windows, and Linux that can ...

13 years, 9 months ago (2011-03-18 14:05:23 UTC) #1

LGTM

Expand All Messages | Collapse All Messages