Issue 4281051: Rewrite of peephole to work on AST

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4281051: Rewrite of peephole to work on AST

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 9 months ago by Eugene Toder

Modified:
9 years ago

Reviewers:
Nick Coghlan

Base URL:
http://hg.python.org/cpython/

Visibility:
Public.

Patch Set 1 #

Patch Set 2 : Update #

Total comments: 1

Created: 13 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2397 lines, -814 lines)			Patch
M	Include/Python-ast.h	View		7 chunks	+18 lines, -30 lines	0 comments	Download
M	Include/compile.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	Lib/ast.py	View		5 chunks	+10 lines, -14 lines	0 comments	Download
A	Lib/test/disutil.py	View		1 chunk	+19 lines, -0 lines	0 comments	Download
M	Lib/test/test_ast.py	View		6 chunks	+58 lines, -56 lines	0 comments	Download
M	Lib/test/test_compile.py	View	1	2 chunks	+44 lines, -0 lines	0 comments	Download
M	Lib/test/test_peepholer.py	View	1	9 chunks	+125 lines, -33 lines	0 comments	Download
M	Lib/test/test_sys_settrace.py	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	Makefile.pre.in	View		3 chunks	+7 lines, -0 lines	0 comments	Download
M	PC/os2emx/python33.def	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	Parser/Python.asdl	View		3 chunks	+6 lines, -8 lines	0 comments	Download
M	Parser/asdl_c.py	View		2 chunks	+16 lines, -8 lines	0 comments	Download
A	Parser/asdl_ct.py	View	1	1 chunk	+260 lines, -0 lines	0 comments	Download
M	Python/Python-ast.c	View		76 chunks	+622 lines, -521 lines	0 comments	Download
M	Python/ast.c	View		16 chunks	+91 lines, -24 lines	0 comments	Download
A	Python/ast_opt.c	View	1	1 chunk	+544 lines, -0 lines	0 comments	Download
A	Python/ast_opt.ct	View	1	1 chunk	+265 lines, -0 lines	0 comments	Download
M	Python/compile.c	View	1	28 chunks	+301 lines, -103 lines	1 comment	Download
M	Python/future.c	View		2 chunks	+3 lines, -7 lines	0 comments	Download
M	Python/symtable.c	View		1 chunk	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Nick Coghlan

13 years, 9 months ago (2011-03-27 11:26:13 UTC) #1

Minor comments to supplement the more general ones on the tracker item.

http://codereview.appspot.com/4281051/diff/2001/Python/compile.c
File Python/compile.c (right):

http://codereview.appspot.com/4281051/diff/2001/Python/compile.c#newcode3185
Python/compile.c:3185: return e->kind == Lit_kind ? PyObject_IsTrue(e->v.Lit.v)
: -1;
This loses the __debug__ special casing.

Expand All Messages | Collapse All Messages