Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(359)

Issue 4280069: Add glu libtess to thirdparty; gyp fixes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 9 months ago by Stephen White
Modified:
13 years, 9 months ago
Reviewers:
bsalomon, reed1
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Add the GLU tesselator source files to third_party. Add a libtess static library build target to the .gyp file (not required by any executable yet). Fix some build errors with SampleApp on Linux and Win32. Add a gyp_skia python script which invokes gyp with the correct arguments, and is recursively callable by the Makefile when skia.gyp is changed.

Patch Set 1 #

Patch Set 2 : Upload the correct patch this time. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7417 lines, -2 lines) Patch
gyp/gyp_skia View 1 1 chunk +76 lines, -0 lines 0 comments Download
gyp/skia.gyp View 1 3 chunks +42 lines, -2 lines 0 comments Download
third_party/glu/LICENSE.txt View 1 1 chunk +31 lines, -0 lines 0 comments Download
third_party/glu/README.skia View 1 1 chunk +39 lines, -0 lines 0 comments Download
third_party/glu/gluos.h View 1 1 chunk +48 lines, -0 lines 0 comments Download
third_party/glu/internal_glu.h View 1 1 chunk +141 lines, -0 lines 0 comments Download
third_party/glu/libtess/GNUmakefile View 1 1 chunk +110 lines, -0 lines 0 comments Download
third_party/glu/libtess/Imakefile View 1 1 chunk +61 lines, -0 lines 0 comments Download
third_party/glu/libtess/README View 1 1 chunk +447 lines, -0 lines 0 comments Download
third_party/glu/libtess/alg-outline View 1 1 chunk +229 lines, -0 lines 0 comments Download
third_party/glu/libtess/dict.h View 1 1 chunk +107 lines, -0 lines 0 comments Download
third_party/glu/libtess/dict.c View 1 1 chunk +117 lines, -0 lines 0 comments Download
third_party/glu/libtess/dict-list.h View 1 1 chunk +107 lines, -0 lines 0 comments Download
third_party/glu/libtess/geom.h View 1 1 chunk +90 lines, -0 lines 0 comments Download
third_party/glu/libtess/geom.c View 1 1 chunk +271 lines, -0 lines 0 comments Download
third_party/glu/libtess/memalloc.h View 1 1 chunk +61 lines, -0 lines 0 comments Download
third_party/glu/libtess/memalloc.c View 1 1 chunk +62 lines, -0 lines 0 comments Download
third_party/glu/libtess/mesh.h View 1 1 chunk +273 lines, -0 lines 0 comments Download
third_party/glu/libtess/mesh.c View 1 1 chunk +796 lines, -0 lines 0 comments Download
third_party/glu/libtess/normal.h View 1 1 chunk +52 lines, -0 lines 0 comments Download
third_party/glu/libtess/normal.c View 1 1 chunk +259 lines, -0 lines 0 comments Download
third_party/glu/libtess/priorityq.h View 1 1 chunk +124 lines, -0 lines 0 comments Download
third_party/glu/libtess/priorityq.c View 1 1 chunk +267 lines, -0 lines 0 comments Download
third_party/glu/libtess/priorityq-heap.h View 1 1 chunk +114 lines, -0 lines 0 comments Download
third_party/glu/libtess/priorityq-heap.c View 1 1 chunk +260 lines, -0 lines 0 comments Download
third_party/glu/libtess/priorityq-sort.h View 1 1 chunk +124 lines, -0 lines 0 comments Download
third_party/glu/libtess/render.h View 1 1 chunk +59 lines, -0 lines 0 comments Download
third_party/glu/libtess/render.c View 1 1 chunk +505 lines, -0 lines 0 comments Download
third_party/glu/libtess/sweep.h View 1 1 chunk +84 lines, -0 lines 0 comments Download
third_party/glu/libtess/sweep.c View 1 1 chunk +1362 lines, -0 lines 0 comments Download
third_party/glu/libtess/tess.h View 1 1 chunk +173 lines, -0 lines 0 comments Download
third_party/glu/libtess/tess.c View 1 1 chunk +639 lines, -0 lines 0 comments Download
third_party/glu/libtess/tessmono.h View 1 1 chunk +78 lines, -0 lines 0 comments Download
third_party/glu/libtess/tessmono.c View 1 1 chunk +209 lines, -0 lines 0 comments Download

Messages

Total messages: 4
Stephen White
13 years, 9 months ago (2011-03-25 17:11:59 UTC) #1
Stephen White
Upload the correct patch this time.
13 years, 9 months ago (2011-03-25 17:13:19 UTC) #2
bsalomon
LGTM. Thanks for the skia.gyp fixes and script!
13 years, 9 months ago (2011-03-25 17:37:11 UTC) #3
Stephen White
13 years, 9 months ago (2011-03-25 17:43:03 UTC) #4
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b