SCSI DMA correctness

Makes the SCSI subsystem correct with regards to DMA-able memory usage.

[Matthew Dempsky, 2011-03-12 02:00:51]

http://codereview.appspot.com/4279046/diff/5001/safte.c
File safte.c (right):

http://codereview.appspot.com/4279046/diff/5001/safte.c#newcode119
safte.c:119: inqbuf = malloc(sizeof(*inqbuf), M_TEMP, M_NOWAIT | M_ZERO);
si isn't needed until the memcmp() on line 168, so you can defer allocating
memory for inqbuf until around line 144.  This will also avoid the memory leaks
on lines 127, 132, 137, and 141.

http://codereview.appspot.com/4279046/diff/5001/safte.c#newcode143
safte.c:143: length = sizeof(inqbuf);
Need to use sizeof(*inqbuf), not sizeof(inqbuf), here.

http://codereview.appspot.com/4279046/diff/5001/safte.c#newcode149
safte.c:149: return (0);
inqbuf leaks here.

http://codereview.appspot.com/4279046/diff/5001/safte.c#newcode283
safte.c:283: return (1);
config is leaked here.

http://codereview.appspot.com/4279046/diff/5001/scsiconf.c
File scsiconf.c (right):

http://codereview.appspot.com/4279046/diff/5001/scsiconf.c#newcode1149
scsiconf.c:1149: if (scsi_inquire_vpd(link, pg, sizeof(pg), SI_PG_SUPPORTED,
Need sizeof(*pg) here.

http://codereview.appspot.com/4279046/diff/5001/scsiconf.c#newcode1187
scsiconf.c:1187: hdr = malloc(sizeof(hdr), M_TEMP, M_WAITOK | M_ZERO);
Need sizeof(*hdr) here.

http://codereview.appspot.com/4279046/diff/5001/scsiconf.c#newcode1194
scsiconf.c:1194: len = sizeof(*hdr) + _2btol(hdr->page_length);
After assigning len, hdr is unused.  You can free the memory and reset hdr to
NULL at this point.

[Matthew Dempsky, 2011-03-12 02:06:00]

http://codereview.appspot.com/4279046/diff/10001/safte.c
File safte.c (right):

http://codereview.appspot.com/4279046/diff/10001/safte.c#newcode284
safte.c:284: return (1);
config is leaked here.

http://codereview.appspot.com/4279046/diff/10001/scsiconf.c
File scsiconf.c (right):

http://codereview.appspot.com/4279046/diff/10001/scsiconf.c#newcode1150
scsiconf.c:1150: if (scsi_inquire_vpd(link, pg, sizeof(pg), SI_PG_SUPPORTED,
Need sizeof(*pg) here.

http://codereview.appspot.com/4279046/diff/10001/scsiconf.c#newcode1266
scsiconf.c:1266: dma_free(pg, sizeof(*pg));
Should be dma_free(pg, len).

http://codereview.appspot.com/4279046/diff/10001/scsiconf.c#newcode1268
scsiconf.c:1268: dma_free(hdr, len);
Should be dma_free(hdr, sizeof(*hdr)).

[Matthew Dempsky, 2011-03-12 02:14:27]

http://codereview.appspot.com/4279046/diff/14001/safte.c
File safte.c (right):

http://codereview.appspot.com/4279046/diff/14001/safte.c#newcode120
safte.c:120: inqbuf = dma_alloc(sizeof(*inqbuf), PR_NOWAIT | PR_ZERO);
si isn't needed until the memcmp() on line 168, so you can defer allocating
memory for inqbuf until around line 144.  This will also avoid the memory leaks
on lines 127, 132, 137, and 141.

http://codereview.appspot.com/4279046/diff/14001/safte.c#newcode144
safte.c:144: length = sizeof(inqbuf);
Need to use sizeof(*inqbuf), not sizeof(inqbuf), here.

http://codereview.appspot.com/4279046/diff/14001/safte.c#newcode150
safte.c:150: return (0);
inqbuf leaks here.

http://codereview.appspot.com/4279046/diff/14001/scsiconf.c
File scsiconf.c (right):

http://codereview.appspot.com/4279046/diff/14001/scsiconf.c#newcode1150
scsiconf.c:1150: if (scsi_inquire_vpd(link, pg, sizeof(pg), SI_PG_SUPPORTED,
Need sizeof(*pg) here.

http://codereview.appspot.com/4279046/diff/14001/st.c
File st.c (right):

http://codereview.appspot.com/4279046/diff/14001/st.c#newcode2151
st.c:2151: return 0;
Should return error here.