Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(14)

Issue 4277063: Fix for the domain inversion localization (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 11 months ago by nicoe
Modified:
14 years, 10 months ago
Reviewers:
ced
Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added some tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -6 lines) Patch
M tryton/common/domain_inversion.py View 1 5 chunks +19 lines, -5 lines 0 comments Download
M tryton/gui/window/view_form/model/field.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
nicoe
14 years, 11 months ago (2011-03-18 13:47:11 UTC) #1
ced
A small unittest will be better http://codereview.appspot.com/4277063/diff/1/tryton/gui/window/view_form/model/field.py File tryton/gui/window/view_form/model/field.py (right): http://codereview.appspot.com/4277063/diff/1/tryton/gui/window/view_form/model/field.py#newcode397 tryton/gui/window/view_form/model/field.py:397: return localize_domain(inverse_leaf(screen_domain), self.name) ...
14 years, 11 months ago (2011-03-18 13:53:50 UTC) #2
nicoe
14 years, 11 months ago (2011-03-18 14:00:36 UTC) #3
ced
14 years, 11 months ago (2011-03-18 14:07:19 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b