Issue 4277063: Fix for the domain inversion localization

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4277063: Fix for the domain inversion localization (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 11 months ago by nicoe

Modified:
14 years, 10 months ago

Reviewers:
ced

Visibility:
Public.

Patch Set 2 : Added some tests #

Created: 14 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -6 lines)			Patch
	M	tryton/common/domain_inversion.py	View	1	5 chunks	+19 lines, -5 lines	0 comments	Download
	M	tryton/gui/window/view_form/model/field.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

ced

A small unittest will be better http://codereview.appspot.com/4277063/diff/1/tryton/gui/window/view_form/model/field.py File tryton/gui/window/view_form/model/field.py (right): http://codereview.appspot.com/4277063/diff/1/tryton/gui/window/view_form/model/field.py#newcode397 tryton/gui/window/view_form/model/field.py:397: return localize_domain(inverse_leaf(screen_domain), self.name) ...

14 years, 11 months ago (2011-03-18 13:53:50 UTC) #2

LGTM

Expand All Messages | Collapse All Messages