Support surrounding-text retrieval.

Support surrounding-text retrieval.

Unlike the GtkIMContext API, IBus automatically retrieves
surrounding-text when certain events occurred to the
client ("before filter_keypress", for example).  This makes the
engine API simpler but causes periodical emission of D-Bus
signals for updating surrounding-text information, which is
unwanted for typical engines.

For this reason, the surrounding-text support is currently
disabled by default.  To enable it, pass
--enable-surrounding-text to configure.  Also, even
surrounding-text support is compiled in, IBus does not start
polling until an engine requests surrounding-text using
ibus_engine_get_surrounding_text().  To make the function work
for the first time, clients should retrieve
initial surrounding-text when the engine is enabled (see ibus_im_context_focus_in() and
_ibus_context_enabled_cb() in client/gtk2/ibusimcontext.c).

BUG=Issue#778
TEST=manual

[Daiki Ueno, 2011-03-29 03:06:30]

Hi,

I'm trying to land the surrounding-text patch, since it has been tested in
Fedora for quite some time and the review of the original patch has done IIRC.

I revised the patch so that:
- surrounding-text support is disabled by default and can be enabled with
configure option
- input context does not start polling until an engine requests surrounding-text

Regards,

[Peng, 2011-04-04 19:21:16]

I apply this CL failed. Please rebase it to HEAD of master branch. Thanks.

On 2011/03/29 03:06:30, Daiki Ueno wrote:
> Hi,
> 
> I'm trying to land the surrounding-text patch, since it has been tested in
> Fedora for quite some time and the review of the original patch has done IIRC.
> 
> I revised the patch so that:
> - surrounding-text support is disabled by default and can be enabled with
> configure option
> - input context does not start polling until an engine requests
surrounding-text
> 
> Regards,

[Peng, 2011-04-04 19:25:39]

http://codereview.appspot.com/4276082/diff/1/src/ibusinputcontext.h
File src/ibusinputcontext.h (right):

http://codereview.appspot.com/4276082/diff/1/src/ibusinputcontext.h#newcode466
src/ibusinputcontext.h:466: * @context: An IBusInputContext.
Please use #IBusInputContext.

http://codereview.appspot.com/4276082/diff/1/src/ibusinputcontext.h#newcode467
src/ibusinputcontext.h:467: * @text: An IBusText surrounding the current cursor
on the application.
#IBusText

http://codereview.appspot.com/4276082/diff/1/src/ibusinputcontext.h#newcode477
src/ibusinputcontext.h:477: * @context: An IBusInputContext.
#IBusInputContext

http://codereview.appspot.com/4276082/diff/1/src/ibusinputcontext.h#newcode479
src/ibusinputcontext.h:479: * FALSE otherwise.
%TRUE

[Daiki Ueno, 2011-04-05 06:22:39]

Thanks for looking at this.  Uploaded a new CL with fixes.

[Daiki Ueno, 2011-04-06 02:02:54]

On 2011/04/05 06:22:39, Daiki Ueno wrote:
> Thanks for looking at this.  Uploaded a new CL with fixes.

I saw that you committed the patch into the git, thanks.
Closing.