Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1629)

Issue 4276081: shakusa: Issue 9: Relax addresses validation. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 5 months ago by shakusa
Modified:
13 years, 5 months ago
Reviewers:
pmy
CC:
publicalerts-eng_google.com
Visibility:
Public.

Description

Misreading of the spec on my part. In CAP 1.2, "addresses" was made explicitly optional when "scope" is "Public" or "Restricted". In earlier versions, it is not explicitly optional, but it is also not explicitly invalid, so it's probably safer to not validate at all in this case.

Patch Set 1 #

Patch Set 2 : Issue 10: Improve references error message. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -20 lines) Patch
M java/build.xml View 1 chunk +1 line, -1 line 0 comments Download
M java/src/com/google/publicalerts/cap/CapException.java View 1 2 chunks +1 line, -3 lines 0 comments Download
M java/src/com/google/publicalerts/cap/CapValidator.java View 1 chunk +1 line, -6 lines 0 comments Download
M java/test/com/google/publicalerts/cap/CapValidatorTest.java View 1 chunk +2 lines, -8 lines 0 comments Download
M validator/build.xml View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3
shakusa
13 years, 5 months ago (2011-03-28 21:37:19 UTC) #1
shakusa
13 years, 5 months ago (2011-03-28 21:40:09 UTC) #2
pmy
13 years, 5 months ago (2011-03-29 18:15:09 UTC) #3
LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b