Reflection for generated classes (issue #137)

[philippe.beaudoin, 2011-03-23 04:50:48]

LGTM, one minor detail.

Your GinBridgeClassLoader looks very useful to perform reflection on
GWT-generated classes. I wonder if it could be used to inject generated classes?

http://codereview.appspot.com/4276072/diff/1/src/com/google/gwt/inject/rebind...
File src/com/google/gwt/inject/rebind/GinBridgeClassLoader.java (right):

http://codereview.appspot.com/4276072/diff/1/src/com/google/gwt/inject/rebind...
src/com/google/gwt/inject/rebind/GinBridgeClassLoader.java:120: throw new
FieldLoadException(e, fieldName, declaringType);
Should we also catch ClassCastException here? If case GWT changes their private
field types we would fail with a more obvious error.

[Aragos, 2011-03-23 23:06:40]

On 2011/03/23 04:50:48, philippe.beaudoin wrote:
> LGTM, one minor detail.
> 
> Your GinBridgeClassLoader looks very useful to perform reflection on
> GWT-generated classes. I wonder if it could be used to inject generated
classes?

You may wonder, but it does not (right now anyways). Generators invoked from Gin
are only run after Gin has terminated.

[Aragos, 2011-03-23 23:06:47]

http://codereview.appspot.com/4276072/diff/1/src/com/google/gwt/inject/rebind...
File src/com/google/gwt/inject/rebind/GinBridgeClassLoader.java (right):

http://codereview.appspot.com/4276072/diff/1/src/com/google/gwt/inject/rebind...
src/com/google/gwt/inject/rebind/GinBridgeClassLoader.java:120: throw new
FieldLoadException(e, fieldName, declaringType);
On 2011/03/23 04:50:48, philippe.beaudoin wrote:
> Should we also catch ClassCastException here? If case GWT changes their
private
> field types we would fail with a more obvious error.

Done.