Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1800)

Issue 4275063: Switched to D3D10 shader compiler. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years ago by apatrick1
Modified:
13 years ago
CC:
angleproject-review_googlegroups.com
Base URL:
http://angleproject.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Switched to D3D10 shader compiler. I figured out how to call in to D3DCompiler_xx.dll and still get the ID3DXConstantTable metadata used by ANGLE. There are more optimization levels available with this compiler and the lowest level (0) allows MetaTunnel and MandelBox to compile their shaders quickly. MetaTunnel still does not render correctly unfortunately. I benchmarked eight of the ShaderToy demos and did not notice any performance regression on an nVidia Quadro FX 380. Intel might be adversely affected. I built ANGLE against D3DCompiler_43.dll, while Chrome still ships with 42. I'm not sure if that will make a difference but I'll rev Chrome soon. I also checked WebGL Aquarium and ran the WebGL conformance tests. This will also let me roll r590 into Chromium. It turns out the ForceSymbolReferences setting I added to the libGLESv2 target caused the linker to sometimes crash when making changes and the changes between r577 and r590 consistently lead to a crash. libGLESv2 now has a hard dependency on D3DCompiler_xx.dll via the call in Program.cpp and this seems to not make the linker crash. Committed: http://code.google.com/p/angleproject/source/detail?r=591

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -27 lines) Patch
M src/build_angle.gyp View 2 chunks +1 line, -3 lines 0 comments Download
M src/libGLESv2/Program.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/libGLESv2/Program.cpp View 4 chunks +49 lines, -23 lines 0 comments Download

Messages

Total messages: 5
apatrick1
Hi Daniel, Can you review? Thanks
13 years ago (2011-03-23 00:12:46 UTC) #1
apatrick1
Oh and I should have mentioned, I tested it on Windows XP as well.
13 years ago (2011-03-23 00:35:56 UTC) #2
dgkoch
Ah yes, I'd forgotten about D3DXGetShaderConstantTable. I'm not terribly keen on the OPTIMIZATION_LEVEL0 bit for ...
13 years ago (2011-03-23 03:58:54 UTC) #3
michaelbraithwaite
Hi, I wanted to check what this means for XP support as it uses a ...
13 years ago (2011-03-28 13:46:07 UTC) #4
apatrick1
13 years ago (2011-03-28 16:24:44 UTC) #5
Michael,

I tested this on Windows XP. The shader compiler in D3DCompiler_43.dll should
work on that platform. It does not depend on the DX10 runtime. We don't intend
to disable support for WebGL permanently in Chrome with XP and ANGLE should work
fine with XP.

If you have issues running Chrome on XP with the "--ignore-gpu-blacklist"
command line switch, you can report a bug either here or on crbug.com, depending
on where you think the bug is.

Al
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b