Issue 4273104: Fix direct-to-stencil clippath rendering

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4273104: Fix direct-to-stencil clippath rendering (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 8 months ago by bsalomon

Modified:
13 years, 8 months ago

Reviewers:
Stephen White, senorblanco, reed1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Patch Set 1 #

Patch Set 2 : improve comments #

Patch Set 3 : actually upload modified file #

Patch Set 4 : trim a couple lines to 80 cols #

Total comments: 1

Created: 13 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -22 lines)			Patch
M	gpu/src/GrGpu.cpp	View	1 2 3	2 chunks	+40 lines, -19 lines	0 comments	Download
M	gpu/src/GrPathRenderer.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	gpu/src/GrPathRenderer.cpp	View		1 chunk	+1 line, -1 line	1 comment	Download
M	gpu/src/GrStencil.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bsalomon

Woops sent without comment. This change should let Stephen's path renderer not have to implement ...

13 years, 8 months ago (2011-03-24 15:24:18 UTC) #2

Stephen White

13 years, 8 months ago (2011-03-24 17:28:01 UTC) #4

http://codereview.appspot.com/4273104/diff/6001/gpu/src/GrPathRenderer.cpp
File gpu/src/GrPathRenderer.cpp (right):

http://codereview.appspot.com/4273104/diff/6001/gpu/src/GrPathRenderer.cpp#ne...
gpu/src/GrPathRenderer.cpp:297: return !single_pass_path(*target, *path, fill);
Thanks, this makes more sense to me now.

Expand All Messages | Collapse All Messages