Issue 4273085: Add auto correct "on" => "ong", and combine some fuzzy pinyin options to save flag bits.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4273085: Add auto correct "on" => "ong", and combine some fuzzy pinyin options to save flag bits. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by Peng

Modified:
13 years, 6 months ago

Reviewers:
Yusuke Sato

CC:
satorux

Base URL:
git@github.com:ibus/ibus-pinyin.git@master

Visibility:
Public.

Description

Add auto correct "on" => "ong", and combine some fuzzy pinyin options to save flag bits. BUG=none TEST=Linux desktop

Patch Set 3 : Update #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2354 lines, -2189 lines)			Patch
M	data/db/android/Makefile.am	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	data/db/open-phrase/Makefile.am	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download
M	scripts/genpytable.py	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	setup/ibus-pinyin-preferences.ui	View		8 chunks	+17 lines, -76 lines	0 comments	Download
M	setup/main.py	View	1	3 chunks	+35 lines, -28 lines	0 comments	Download
M	src/Makefile.am	View	1 2	2 chunks	+18 lines, -7 lines	0 comments	Download
M	src/PYConfig.cc	View		2 chunks	+3 lines, -0 lines	0 comments	Download
M	src/PYPinyinParserTable.h	View		655 chunks	+2247 lines, -2049 lines	0 comments	Download
M	src/PYTypes.h	View		1 chunk	+27 lines, -26 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Peng

http://codereview.appspot.com/4273085/diff/1/src/PYPinyinParserTable.h File src/PYPinyinParserTable.h (right): http://codereview.appspot.com/4273085/diff/1/src/PYPinyinParserTable.h#newcode551 src/PYPinyinParserTable.h:551: { /* 61 */ This file is generated by ...

13 years, 6 months ago (2011-03-21 14:26:07 UTC) #2

Yusuke Sato

13 years, 6 months ago (2011-03-21 15:38:01 UTC) #3

lgtm

On 2011/03/21 14:26:07, Peng wrote:
> http://codereview.appspot.com/4273085/diff/1/src/PYPinyinParserTable.h
> File src/PYPinyinParserTable.h (right):
> 
>
http://codereview.appspot.com/4273085/diff/1/src/PYPinyinParserTable.h#newcod...
> src/PYPinyinParserTable.h:551: {  /* 61 */
> This file is generated by scirpt genpytable.py
> 
> http://codereview.appspot.com/4273085/diff/1/src/PYTypes.h
> File src/PYTypes.h (right):
> 
> http://codereview.appspot.com/4273085/diff/1/src/PYTypes.h#newcode121
> src/PYTypes.h:121: #define PINYIN_FUZZY_ING_IN         (1U << 28)
> only uses "an" => "ang" & "ang" => "an". and uses them replace "ian" =>
"iang",
> "uan" => "uang", "iang" => "ian", "uang" => "uan"

Expand All Messages | Collapse All Messages