Issue 4273062: Add SK_API to SkCreateTypefaceFromLOGFONT.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4273062: Add SK_API to SkCreateTypefaceFromLOGFONT. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 10 months ago by Chris Guillory

Modified:
13 years, 10 months ago

Reviewers:
Steve VanDeBogart

CC:
skia-review_googlegroups.com, reed1

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Add SK_API to SkCreateTypefaceFromLOGFONT. Committed: http://code.google.com/p/skia/source/detail?r=945

Patch Set 1 #

Total comments: 1

Created: 13 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	include/ports/SkTypeface_win.h	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Steve VanDeBogart

http://codereview.appspot.com/4273062/diff/1/include/ports/SkTypeface_win.h File include/ports/SkTypeface_win.h (right): http://codereview.appspot.com/4273062/diff/1/include/ports/SkTypeface_win.h#newcode28 include/ports/SkTypeface_win.h:28: SK_API extern SkTypeface* SkCreateTypefaceFromLOGFONT(const LOGFONT&); Do you need to ...

13 years, 10 months ago (2011-03-16 00:17:03 UTC) #2

Chris Guillory

On 2011/03/16 00:17:03, Steve VanDeBogart wrote: > http://codereview.appspot.com/4273062/diff/1/include/ports/SkTypeface_win.h > File include/ports/SkTypeface_win.h (right): > > http://codereview.appspot.com/4273062/diff/1/include/ports/SkTypeface_win.h#newcode28 ...

13 years, 10 months ago (2011-03-16 00:23:06 UTC) #3

LGTM

Expand All Messages | Collapse All Messages