Issue 4273059: code review 4273059: crypto/ecdsa: truncate hash values.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4273059: code review 4273059: crypto/ecdsa: truncate hash values. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 2 months ago by agl1

Modified:
14 years, 2 months ago

Reviewers:

CC:
bradfitz, r, golang-dev

Visibility:
Public.

Description

crypto/ecdsa: truncate hash values. There is some disagreement about how to deal with hash values larger than the curve order size. We choose to follow OpenSSL's lead here.

Patch Set 1 #

Patch Set 2 : diff -r b6cde4cc8d34 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r b6cde4cc8d34 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 87209dfd5825 https://go.googlecode.com/hg/ #

Created: 14 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -2 lines)			Patch
	M	src/pkg/crypto/ecdsa/ecdsa.go	View	1	4 chunks	+23 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

agl1

Hello bradfitzgo, r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/

14 years, 2 months ago (2011-03-16 14:42:40 UTC) #3

agl1

14 years, 2 months ago (2011-03-16 14:43:02 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=9fd50a9592b5 ***

crypto/ecdsa: truncate hash values.

There is some disagreement about how to deal with hash values larger
than the curve order size. We choose to follow OpenSSL's lead here.

R=bradfitzgo, r
CC=golang-dev
http://codereview.appspot.com/4273059

Expand All Messages | Collapse All Messages