Issue 4273041: Use Type3 fonts for platforms that don't yet support SkFontHost::GetAdvancedTypefaceMetrics.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4273041: Use Type3 fonts for platforms that don't yet support SkFontHost::GetAdvancedTypefaceMetrics. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by Steve VanDeBogart

Modified:
13 years, 6 months ago

Reviewers:
Chris Guillory, reed1

CC:
skia-review_googlegroups.com, bsalomon

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Description

Use Type3 fonts for platforms that don't yet support SkFontHost::GetAdvancedTypefaceMetrics. Committed: http://code.google.com/p/skia/source/detail?r=922

Patch Set 3 : Address comments #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -29 lines)			Patch
	M	include/pdf/SkPDFFont.h	View		2 chunks	+6 lines, -2 lines	0 comments	Download
	M	src/pdf/SkPDFFont.cpp	View	1 2	9 chunks	+46 lines, -27 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Chris Guillory

http://codereview.appspot.com/4273041/diff/2001/src/pdf/SkPDFFont.cpp File src/pdf/SkPDFFont.cpp (right): http://codereview.appspot.com/4273041/diff/2001/src/pdf/SkPDFFont.cpp#newcode463 src/pdf/SkPDFFont.cpp:463: SkAdvancedTypefaceMetrics::FontType type = Need to initialize to fontInfo->fType if ...

13 years, 6 months ago (2011-03-10 21:35:24 UTC) #2

Steve VanDeBogart

13 years, 6 months ago (2011-03-10 21:43:06 UTC) #3

LGTM

Expand All Messages | Collapse All Messages