Issue 4272070: Store content streams in an SkStream instead of an SkString (64k size limit).

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4272070: Store content streams in an SkStream instead of an SkString (64k size limit). (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 6 months ago by Steve VanDeBogart

Modified:
13 years, 6 months ago

Reviewers:
Chris Guillory

CC:
skia-review_googlegroups.com, reed1

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Description

Store content streams in an SkStream instead of an SkString (64k size limit). Committed: http://code.google.com/p/skia/source/detail?r=1011

Patch Set 1 #

Total comments: 1

Patch Set 2 : toPDFColor -> emitPDFColor #

Created: 13 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+127 lines, -115 lines)			Patch
M	include/pdf/SkPDFDevice.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	include/pdf/SkPDFTypes.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	include/pdf/SkPDFUtils.h	View		1 chunk	+9 lines, -9 lines	0 comments	Download
M	src/pdf/SkPDFDevice.cpp	View	1	18 chunks	+61 lines, -56 lines	0 comments	Download
M	src/pdf/SkPDFFont.cpp	View		3 chunks	+14 lines, -6 lines	0 comments	Download
M	src/pdf/SkPDFTypes.cpp	View		3 chunks	+9 lines, -10 lines	0 comments	Download
M	src/pdf/SkPDFUtils.cpp	View		3 chunks	+31 lines, -31 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Chris Guillory

13 years, 6 months ago (2011-03-28 16:00:06 UTC) #2

LGTM. One nit.

http://codereview.appspot.com/4272070/diff/1/src/pdf/SkPDFDevice.cpp
File src/pdf/SkPDFDevice.cpp (right):

http://codereview.appspot.com/4272070/diff/1/src/pdf/SkPDFDevice.cpp#newcode41
src/pdf/SkPDFDevice.cpp:41: void toPDFColor(SkColor color, SkWStream* result) {
Nit: Function is no longer returning a value. emitPDFColor(..)?

Expand All Messages | Collapse All Messages