Use md5 hash for indexing translation

[nicoe, 2011-04-08 13:28:59]

http://codereview.appspot.com/4271067/diff/1/trytond/ir/translation.py
File trytond/ir/translation.py (right):

http://codereview.appspot.com/4271067/diff/1/trytond/ir/translation.py#newcode96
trytond/ir/translation.py:96: while True:
Would be more clear without the while True

http://codereview.appspot.com/4271067/diff/1/trytond/ir/translation.py#newcod...
trytond/ir/translation.py:153: return md5.new(src.encode('utf-8')).hexdigest()
I would replace this call to a simple md5(src.encode('utf-8')).hexdigest()
But the import have to be tweaked to this
try:
   from hashlib import md5
except ImportError:
   from md5 import md5

http://codereview.appspot.com/4271067/diff/1/trytond/ir/ui/view.py
File trytond/ir/ui/view.py (right):

http://codereview.appspot.com/4271067/diff/1/trytond/ir/ui/view.py#newcode149
trytond/ir/ui/view.py:149: string_md5 = translation_obj.get_src_md5(string or
'')
Maybe putting the logic behind the case where string is True in get_src_md5 is a
good idea (I already saw 3 times the "or ''" idiom)

[ced, 2011-04-08 14:20:52]

http://codereview.appspot.com/4271067/diff/1/trytond/ir/translation.py
File trytond/ir/translation.py (right):

http://codereview.appspot.com/4271067/diff/1/trytond/ir/translation.py#newcode96
trytond/ir/translation.py:96: while True:
On 2011/04/08 13:28:59, nicoe wrote:
> Would be more clear without the while True

Done.

http://codereview.appspot.com/4271067/diff/1/trytond/ir/translation.py#newcod...
trytond/ir/translation.py:153: return md5.new(src.encode('utf-8')).hexdigest()
On 2011/04/08 13:28:59, nicoe wrote:
> I would replace this call to a simple md5(src.encode('utf-8')).hexdigest()
> But the import have to be tweaked to this
> try:
>    from hashlib import md5
> except ImportError:
>    from md5 import md5

Done.

http://codereview.appspot.com/4271067/diff/1/trytond/ir/ui/view.py
File trytond/ir/ui/view.py (right):

http://codereview.appspot.com/4271067/diff/1/trytond/ir/ui/view.py#newcode149
trytond/ir/ui/view.py:149: string_md5 = translation_obj.get_src_md5(string or
'')
On 2011/04/08 13:28:59, nicoe wrote:
> Maybe putting the logic behind the case where string is True in get_src_md5 is
a
> good idea (I already saw 3 times the "or ''" idiom)

Done.

[nicoe, 2011-04-08 19:25:53]

LGTM