Issue 4260052: GCC visibility attributes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 4260052: GCC visibility attributes

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 1 month ago by Thomas Wouters

Modified:
7 years ago

Reviewers:

Visibility:
Public.

Description

Patch to add explicit GCC visibility attributes (when using gcc 4.x or later) to the PyAPI macros. The visibility attributes are necessary to use GCC's -fvisibility=hidden argument, which changes the default visibility. See http://gcc.gnu.org/wiki/Visibility.

Patch Set 1 #

Created: 13 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -30 lines)			Patch
M	Include/pyport.h	View	1 chunk	+43 lines, -24 lines	0 comments	Download
M	Modules/_ctypes/_ctypes_test.c	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Modules/_json.c	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Modules/cjkcodecs/cjkcodecs.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Modules/nismodule.c	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Python/getargs.c	View	2 chunks	+0 lines, -2 lines	0 comments	Download